Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade preferences controller to base controller v2 #27308

Closed
wants to merge 14 commits into from

Conversation

kanthesha
Copy link
Contributor

@kanthesha kanthesha commented Sep 20, 2024

Description

In this PR, we want to bring PreferencesController up to date with our latest controller patterns by upgrading to BaseControllerV2.

Open in GitHub Codespaces

Related issues

Fixes: #25917

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kanthesha kanthesha changed the title upgrade preferences controller to base controller v2 feat: upgrade preferences controller to base controller v2 Sep 20, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@kanthesha
Copy link
Contributor Author

This has been replaced with this PR.

@kanthesha kanthesha closed this Sep 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate PreferencesController to BaseController v2
1 participant