Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snap): Use default buttons when hideSnapsBranding is true #27303

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 20, 2024

Description

This PR makes the button not use the snap branding when the hideSnapsBranding flag is set to true.

It also fixes an issue with the snap homepage footer having a margin when only one button is rendered in the footer.

The snap-footer-button was also renamed snap-ui-renderer__footer-button to conform to the conventional naming of ui elements used in the snap-ui-renderer

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Go to test-snaps
  2. Try the preinstalled example snap

Screenshots/Recordings

Before

image

image

After

image

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested review from a team as code owners September 20, 2024 12:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 20, 2024
Mrtenz
Mrtenz previously approved these changes Sep 20, 2024
david0xd
david0xd previously approved these changes Sep 20, 2024
@GuillaumeRx GuillaumeRx dismissed stale reviews from david0xd and Mrtenz via f85f2b0 September 20, 2024 13:28
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@GuillaumeRx GuillaumeRx merged commit c323433 into develop Sep 20, 2024
75 of 77 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/change-button-colors branch September 20, 2024 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants