-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snap): Use default buttons when hideSnapsBranding
is true
#27303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Mrtenz
previously approved these changes
Sep 20, 2024
david0xd
previously approved these changes
Sep 20, 2024
david0xd
approved these changes
Sep 20, 2024
Mrtenz
approved these changes
Sep 20, 2024
Quality Gate failedFailed conditions |
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Sep 20, 2024
metamaskbot
added
release-12.5.0
Issue or pull request that will be included in release 12.5.0
and removed
release-12.6.0
Issue or pull request that will be included in release 12.6.0
labels
Sep 29, 2024
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.5.0
Issue or pull request that will be included in release 12.5.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the button not use the snap branding when the
hideSnapsBranding
flag is set totrue
.It also fixes an issue with the snap homepage footer having a margin when only one button is rendered in the footer.
The
snap-footer-button
was also renamedsnap-ui-renderer__footer-button
to conform to the conventional naming of ui elements used in thesnap-ui-renderer
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist