test: [POM] Migrate Snap Account Settings to page object model #27302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…ement missing methods in HomePage
…ceValidation, and revert login-page.ts
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…s test to use new page objects
… implement missing page objects and methods
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
changed the title
chloeYue
changed the title
Builds ready [df51f72]
Page Load Metrics (1861 ± 101 ms)
Bundle size diffs
|
chloeYue
reviewed
Sep 24, 2024
chloeYue
reviewed
Sep 24, 2024
chloeYue
reviewed
Sep 24, 2024
chloeYue
reviewed
Sep 24, 2024
chloeYue
reviewed
Sep 24, 2024
chloeYue
reviewed
Sep 24, 2024
chloeYue
reviewed
Sep 24, 2024
Builds ready [409d6be]
Page Load Metrics (1813 ± 67 ms)
Bundle size diffs
|
seaona
reviewed
Sep 24, 2024
Comment on lines
57
to
58
| this.closeAccountModalButton = 'button[aria-label="Close"]'; | ||
| this.closeEditLabelButton = 'button[aria-label="Close"]'; |
There was a problem hiding this comment.
these two selectors are the same, I'm thinking if we can find a better selector for both, maybe using a test-id (if it's not too complex to add)
There was a problem hiding this comment.
oh, nice catch, thanks! I found that the close button for modals on the account list is the same, and since we don't have case where multiple modals are open on the account list, I will keep only one selector for the close button on different modals in account list.
seaona
reviewed
Sep 24, 2024
| @@ -103,16 +111,30 @@ class AccountListPage { | |||
| await this.driver.clickElement(this.closeEditLabelButton); | |||
| } | |||
|
|
|||
| async closeAccountModal(): Promise<void> { | |||
| console.log(`Open add account modal in account list`); | |||
There was a problem hiding this comment.
Maybe the log should say "Close" ?
There was a problem hiding this comment.
nice catch, corrected, thanks !
seaona
reviewed
Sep 24, 2024
| title: this.test?.fullTitle(), | ||
| }, | ||
| async ({ driver }: { driver: Driver }) => { | ||
| await loginWithBalanceValidation(driver); | ||
| await loginWithBalanceValidation(driver, '0'); |
There was a problem hiding this comment.
mmm I think we might want to tweak this function. Instead of having to pass manually the balance, we could use the same approach for the other loginWithBalanceValidation function we have, where we query directly ganache, so there's no need to pass any balance manually.
What do you think?
const logInWithBalanceValidation = async (driver, ganacheServer) => {
await unlockWallet(driver);
// Wait for balance to load
await locateAccountBalanceDOM(driver, ganacheServer);
};
and here the implementation of locate balance using ganache:
const locateAccountBalanceDOM = async (
driver,
ganacheServer,
address = null,
) => {
const balanceSelector = '[data-testid="eth-overview__primary-currency"]';
if (ganacheServer) {
const balance = await ganacheServer.getBalance(address);
await driver.waitForSelector({
css: balanceSelector,
text: `${balance} ETH`,
});
} else {
await driver.findElement(balanceSelector);
}
};
``
There was a problem hiding this comment.
make sense, i made the changes in this commit: 74f6504
|
Builds ready [74f6504]
Page Load Metrics (1776 ± 81 ms)
Bundle size diffs
|
seaona
reviewed
Sep 25, 2024
| await loginWithoutBalanceValidation(driver, password); | ||
| // Verify the expected balance on the homepage | ||
| if (ganacheServer) { | ||
| await new HomePage(driver).check_ganacheBalanceIsDisplayed(ganacheServer); |
seaona
approved these changes
Sep 25, 2024
chloeYue
approved these changes
Sep 25, 2024
metamaskbot
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrate snap account settings test to page object model(POM) pattern, enhancing code maintainability, and improving test reliability.
Also improved the implementation of login methods so we query directly ganache, and there's no need to pass any balance manually.
Description
Related issues
Fixes: #27343
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist