-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Currently extension supporty connect to OneKey via Trezor, but we dont have metric to log this when imported the accounts. #27296
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…rezor' into feat/log-metric-for-oneKey-via-trezor
…l field is undefined as well.
…all unit tests broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint failing
Builds ready [6297cf3]
Page Load Metrics (1886 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Quality Gate passedIssues Measures |
Builds ready [02b8df2]
Page Load Metrics (1737 ± 97 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This have been resolved. |
Description
Currently extension supporty connect to OneKey via Trazor, but we dont have metric to log this when imported the accounts.
This PR is created for this purpose, and i have confirmed with Alex that we should log
OneKey via Trezor
inaccount_hardware_type
field in our AccountAdded metric.Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/586
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist