Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Ethereum logo to purple #27295

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Sep 19, 2024

Description

Updates ETH token and network icon to purple for better visibility on light mode.

Open in GitHub Codespaces

Related issues

Issue: #26936
Jira: https://consensyssoftware.atlassian.net/browse/MMASSETS-378

Manual testing steps

Check to see that Ethereum token and network logos are the purple one

@amandaye0h the figma design logo had a white border. I modified the svg to remove this border, but can you please check that it looks alright to you?

Screenshots/Recordings

Before

Screenshot 2024-09-19 at 3 37 49 PM Screenshot 2024-09-19 at 3 38 12 PM

After

Screenshot 2024-09-19 at 3 33 55 PM Screenshot 2024-09-19 at 3 34 23 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review September 19, 2024 22:38
@gambinish gambinish requested a review from a team as a code owner September 19, 2024 22:38
@metamaskbot
Copy link
Collaborator

Builds ready [02e325a]
Page Load Metrics (1775 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15472267177217383
domContentLoaded15092220174417082
load15462265177517182
domInteractive18135382914
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

@amandaye0h amandaye0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@metamaskbot
Copy link
Collaborator

Builds ready [6b85209]
Page Load Metrics (1655 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15022379165718086
domContentLoaded14862344163117484
load14952380165517986
domInteractive156330115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Sep 20, 2024

@gambinish gambinish merged commit 2550abc into develop Sep 20, 2024
76 of 77 checks passed
@gambinish gambinish deleted the chore/mmassets-378_update-white-eth-logo branch September 20, 2024 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [369473c]
Page Load Metrics (1661 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14362214165419292
domContentLoaded14142071162717282
load14182240166120197
domInteractive20182463919
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants