Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make sonarcloud failures non-blocking #27289

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Sep 19, 2024

Description

Sonarcloud is failing some PRs based on pre-existing issues present in files that a PR edits. We will make it non-blocking until that is resolved

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested a review from a team as a code owner September 19, 2024 17:26
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm changed the title Update sonar-project.properties Make sonarcloud failures non-blocking Sep 19, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

@danjm danjm changed the title Make sonarcloud failures non-blocking chore: Make sonarcloud failures non-blocking Sep 19, 2024
@danjm danjm merged commit 0fcc063 into develop Sep 19, 2024
84 of 87 checks passed
@danjm danjm deleted the turn-sonarcloud-off branch September 19, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1620224]
Page Load Metrics (1835 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15942147184213565
domContentLoaded15252099180512661
load15292158183514369
domInteractive14156462914
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants