Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] migrate Account Custom Name to page object model #27283

Merged
merged 23 commits into from
Sep 23, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 19, 2024

Description

This pull request migrate account custom name interactions to page object model(POM) pattern, enhancing code maintainability, and improving test reliability. It also includes migration for the test file test/e2e/tests/account/account-custom-name.spec.ts as example

Open in GitHub Codespaces

Related issues

Fixes: #27163

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue self-assigned this Sep 19, 2024
@chloeYue chloeYue added team-extension-platform team-ai AI team (for the Devin AI bot) labels Sep 19, 2024
@chloeYue chloeYue changed the title Draft: Account Custom Name Migration test: Draft: Account Custom Name Migration Sep 19, 2024
@chloeYue chloeYue changed the title test: Draft: Account Custom Name Migration test: migrate Account Custom Name migration to page object model Sep 19, 2024
@chloeYue chloeYue changed the title test: migrate Account Custom Name migration to page object model test: migrate Account Custom Name to page object model Sep 19, 2024
@chloeYue chloeYue changed the title test: migrate Account Custom Name to page object model test: [POM] migrate Account Custom Name to page object model Sep 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a1e1502]
Page Load Metrics (1873 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15792275187115675
domContentLoaded15722257183315172
load15802273187316178
domInteractive18194473919
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review September 20, 2024 07:56
@chloeYue chloeYue requested a review from a team as a code owner September 20, 2024 07:56
Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added some nits

test/e2e/tests/account/account-custom-name.spec.ts Outdated Show resolved Hide resolved
test/e2e/tests/account/account-custom-name.spec.ts Outdated Show resolved Hide resolved
test/e2e/tests/account/account-pin-unpin.spec.ts Outdated Show resolved Hide resolved
test/e2e/tests/account/account-hide-unhide.spec.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@metamaskbot
Copy link
Collaborator

Builds ready [ccc68df]
Page Load Metrics (1841 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39723921756379182
domContentLoaded15682239179618991
load158723821841213103
domInteractive206538168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue merged commit 4b4d8d5 into develop Sep 23, 2024
76 of 77 checks passed
@chloeYue chloeYue deleted the devin-account-custom-name-migration branch September 23, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-ai AI team (for the Devin AI bot) team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[POM][Devin] Create page classes for accounts and provide more accounts e2e tests migration examples
3 participants