Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no sentry DSN #27272

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: no sentry DSN #27272

merged 2 commits into from
Sep 19, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Sep 19, 2024

Description

Fix extension loading with no Sentry DSN, typically provided by SENTRY_DSN_DEV environment variable.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Sep 19, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner September 19, 2024 10:20
Copy link

sonarcloud bot commented Sep 19, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [f919f6f]
Page Load Metrics (2000 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint49227161936390187
domContentLoaded16252598196618790
load16842702200020096
domInteractive15173453416
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 297 Bytes (0.00%)

@matthewwalsh0 matthewwalsh0 merged commit d8b1477 into develop Sep 19, 2024
77 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/no-sentry-dsn branch September 19, 2024 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 19, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants