test: [POM] create ResetPasswordPage for e2e tests and migrate 2 test files to POM #27244

devin-ai-integration · 2024-09-18T10:26:31Z

Description

This pull request creates the ResetPasswordPage class for the E2E tests page object model and migrates 2 test files in test/e2e/tests/account to POM and TypeScript, with enhanced log messages.

I have placed the test test/e2e/tests/account/metamask-responsive-ui.spec.js outside the account folder because these tests don't test account functionality. They are for testing the extension UI in small viewports.

Related issues

Fixes: #27245

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-18T10:26:48Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud · 2024-09-18T11:31:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-18T12:16:19Z

Builds ready [4618b4a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1810 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	213	2082	1560	542	260
		domContentLoaded	1471	2406	1779	205	98
		load	1487	2416	1810	205	98
		domInteractive	22	112	52	25	12

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

DDDDDanica · 2024-09-18T13:06:46Z

LGTM !

seaona · 2024-09-18T14:08:45Z

test/e2e/page-objects/pages/account-list-page.ts

@@ -33,6 +33,19 @@ class AccountListPage {
      '.multichain-account-menu-popover__list--menu-item-hidden-account [data-testid="account-list-item-menu-button"]';
  }

+  async check_pageIsLoaded(): Promise<void> {


nit: maybe to follow the same as what we did in the other PR, I would suggest to place the checks at the end

oh or maybe is it better to order everything alphabetically? As I see that in other places it is ordered alphabetically including the checks. In that case we can leave this as it is, but we can modify the order of the other page (linked PR above), in another PR

Thanks for pointing out @seaona ! What I'm thinking for the order is: check_pageIsLoaded() first, followed by action methods ordered alphabetically, and then all check_ methods ordered alphabetically(as they all start with check_).
The reason for placing check_pageIsLoaded() first is that all page classes will have this specific method, and when we create an object for the page, we usually need to call it before performing other actions. Thus, putting this specific method at the beginning will make it easier to find.
What do you think about this approach? If you agree, we can make it a standard.

…wed by action and check methods alphabetically

sonarcloud · 2024-09-18T18:44:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-18T19:21:18Z

Builds ready [c541f90]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1763 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	212	1928	1547	565	271
		domContentLoaded	1506	1887	1741	106	51
		load	1517	1928	1763	112	54
		domInteractive	15	90	41	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-09-29T17:09:45Z

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

devin-ai-integration bot and others added 2 commits September 18, 2024 09:54

Cherry-picked files from devin-accounts-tests-migration branch

83e4ff0

corrections

4ef6cc7

devin-ai-integration bot requested a review from a team as a code owner September 18, 2024 10:26

chloeYue marked this pull request as draft September 18, 2024 11:23

chloeYue self-assigned this Sep 18, 2024

chloeYue added team-extension-platform team-ai AI team (for the Devin AI bot) labels Sep 18, 2024

chloeYue changed the title ~~MetaMask Extension Password Page Tests Migration~~ test: MetaMask Extension Password Page Tests Migration Sep 18, 2024

correction

4618b4a

chloeYue changed the title ~~test: MetaMask Extension Password Page Tests Migration~~ test: [POM] create ResetPasswordPage for e2e tests and migrate 2 test files to POM Sep 18, 2024

chloeYue marked this pull request as ready for review September 18, 2024 12:20

DDDDDanica previously approved these changes Sep 18, 2024

View reviewed changes

seaona reviewed Sep 18, 2024

View reviewed changes

seaona previously approved these changes Sep 18, 2024

View reviewed changes

Reorder methods in AccountListPage: check_pageIsLoaded() first, follo…

717e1b2

…wed by action and check methods alphabetically

devin-ai-integration bot dismissed stale reviews from seaona and DDDDDanica via 717e1b2 September 18, 2024 16:20

devin-ai-integration bot and others added 2 commits September 18, 2024 16:33

Revert last commit 717e1b2 to undo changes in account-list-page.ts

8691d35

Merge branch 'develop' into devin-password-page-tests-migration

c541f90

chloeYue requested a review from seaona September 19, 2024 07:19

chloeYue approved these changes Sep 19, 2024

View reviewed changes

DDDDDanica approved these changes Sep 19, 2024

View reviewed changes

chloeYue merged commit a1962dc into develop Sep 20, 2024
77 checks passed

chloeYue deleted the devin-password-page-tests-migration branch September 20, 2024 07:53

github-actions bot locked and limited conversation to collaborators Sep 20, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024

metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [POM] create ResetPasswordPage for e2e tests and migrate 2 test files to POM #27244

test: [POM] create ResetPasswordPage for e2e tests and migrate 2 test files to POM #27244

devin-ai-integration bot commented Sep 18, 2024 •

edited by chloeYue

Loading

github-actions bot commented Sep 18, 2024

sonarcloud bot commented Sep 18, 2024

metamaskbot commented Sep 18, 2024

DDDDDanica commented Sep 18, 2024

seaona Sep 18, 2024

seaona Sep 18, 2024

chloeYue Sep 18, 2024 •

edited

Loading

sonarcloud bot commented Sep 18, 2024

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 29, 2024

test: [POM] create ResetPasswordPage for e2e tests and migrate 2 test files to POM #27244

test: [POM] create ResetPasswordPage for e2e tests and migrate 2 test files to POM #27244

Conversation

devin-ai-integration bot commented Sep 18, 2024 • edited by chloeYue Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 18, 2024

sonarcloud bot commented Sep 18, 2024

Quality Gate passed

metamaskbot commented Sep 18, 2024

DDDDDanica commented Sep 18, 2024

seaona Sep 18, 2024

Choose a reason for hiding this comment

seaona Sep 18, 2024

Choose a reason for hiding this comment

chloeYue Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Sep 18, 2024

Quality Gate passed

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 29, 2024

devin-ai-integration bot commented Sep 18, 2024 •

edited by chloeYue

Loading

chloeYue Sep 18, 2024 •

edited

Loading