fix: fix percentage change for non standard currencies

[sahar-fehri]

Description

PR that fixes error when users choose a currency that is non standard currency code.

Reproduction steps:
Open the Settings > General menu
Change the Currency Conversion setting to DASH
Click outside of the extension window to close it, then reopen the extension

Related issues

Fixes:

Manual testing steps

1. Go to Settings > General menu
2. Change the Currency Conversion setting to DASH
3. Go back to home page; and you should not see an error

Screenshots/Recordings

Before

Screen.Recording.2024-09-18.at.10.46.17.mov

After

Screen.Recording.2024-09-18.at.10.44.00.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sahar-fehri]

With standard currency codes, Intl.NumberFormat with currency argument would return the right currency formatted exp "$10" or "€5";

With non standard currency codes, we could do something like
`.format(balanceChange as number)} ${fiatCurrency}``; which would result in displaying the name of the currency (screenshot)

I thought it is not necessary and we can display just the value for non standard currencies;
Can update if you guys think it looks better with currency

[bergeron]

I think just the value is okay because the currency symbol is shown on the line above

[metamaskbot]

Builds ready [4e884c5]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1821 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	400	2154	1757	358	172
		domContentLoaded	1511	2112	1792	166	80
		load	1556	2122	1821	172	83
		domInteractive	14	209	44	41	20

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 138 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[darkwing]

The try/catch looks reasonable to me such that we aren't needing to account for what a browser would consider a valid code.