Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caip multichain caip 27 api spec tests #27229

Merged
merged 10 commits into from
Sep 25, 2024

Conversation

shanejonas
Copy link
Contributor

@shanejonas shanejonas commented Sep 17, 2024

Description

This adds api spec tests that utilize externally_connectable as well as caip-27 requests to wrap the "legacy" api-spec tests.

It refactors a lot into transform.ts to help reduce duplication since we want to test it the same way as our current api-spec tests.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. CHAIN_PERMISSIONS=1 BARAD_DUR=1 yarn build:test
  2. yarn test:api-spec-multichain
  3. see multiple html reporters pop up with all passing.

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shanejonas shanejonas requested review from a team as code owners September 17, 2024 21:02
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas shanejonas changed the base branch from develop to caip-multichain September 17, 2024 21:02
@shanejonas
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested a review from a team as a code owner September 17, 2024 21:14
@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

Copy link

socket-security bot commented Sep 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 255 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT

@shanejonas shanejonas merged commit dd02132 into caip-multichain Sep 25, 2024
16 of 18 checks passed
@shanejonas shanejonas deleted the caip-multichain-caip-27-api-spec-tests branch September 25, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants