Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cherry-pick): Adding "cookie id" to metrics event (#26697) #27227

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Sep 17, 2024

Cherry picking #26697 to V12.3.0

#26697 sets up a stream communication with the label 'metamask-cookie-handler'. The data sent from the page will be intercepted at the content-script and forwarded to the extension. The 'ga_client_id' sent from the page is saved as marketingCampaignCookieId in the metaMetricsController state and fetched when building the context for each event.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner September 17, 2024 19:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy added team-extension-platform release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Sep 17, 2024
@danjm danjm merged commit 3373b9a into Version-v12.3.0 Sep 18, 2024
72 of 74 checks passed
@danjm danjm deleted the v12.3.0-cherry-pick-attribution-pr branch September 18, 2024 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants