test(TXL-308): initial e2e for stx using swaps #27215

dbrans · 2024-09-17T13:00:25Z

Description

Initial e2e test for stx

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-17T13:00:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud · 2024-09-18T15:08:33Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dbrans · 2024-09-18T17:23:35Z

privacy-snapshot.json

Diff summary

Added:

"crypto.com"

"transaction.api.cx.metamask.io"

"verify.walletconnect.com"

metamaskbot · 2024-09-18T20:53:56Z

Builds ready [fff9e5d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1917 ± 67 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	248	2176	1657	598	287
		domContentLoaded	1692	2167	1891	131	63
		load	1703	2195	1917	139	67
		domInteractive	14	144	44	31	15

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 177 Bytes (0.00%)
ui: 111 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-09-20T20:12:56Z

Builds ready [ad69471]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1844 ± 110 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	299	2518	1758	395	190
		domContentLoaded	1558	2404	1804	208	100
		load	1568	2531	1844	229	110
		domInteractive	13	99	36	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 177 Bytes (0.00%)
ui: 111 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/tests/smart-transactions/smart-transactions.spec.ts

metamaskbot · 2024-09-23T16:11:45Z

Builds ready [b0c6e80]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1839 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	328	2326	1686	461	221
		domContentLoaded	1479	2313	1818	209	101
		load	1491	2388	1839	217	104
		domInteractive	13	192	48	40	19

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 177 Bytes (0.00%)
ui: 111 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-09-23T19:29:47Z

Builds ready [db9d7f3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1695 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1554	2179	1691	146	70
		domContentLoaded	1547	2083	1665	131	63
		load	1562	2186	1695	143	69
		domInteractive	15	201	51	43	21

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 177 Bytes (0.00%)
ui: 111 Bytes (0.00%)
common: 0 Bytes (0.00%)

dan437 · 2024-09-23T16:05:46Z

test/e2e/tests/swaps/shared.ts

  const summary = await driver.waitForSelector(
    '[data-testid="exchange-rate-display-quote-rate"]',
  );
  const summaryText = await summary.getText();
+  console.log('============\nsummaryText\n============', {


Do we want to remove this one?

dan437 · 2024-09-24T08:50:10Z

test/e2e/mock-e2e.js

+            mobileActive: true,
+            extensionActive: true,
+          },
+          localhost: {


Do we still need this?

dan437 · 2024-09-24T08:51:01Z

test/e2e/tests/smart-transactions/mock-requests-for-swap-test.ts

+      method: 'eth_getBalance',
+      params: ['0x5cfe73b6021e818b776b421b1c4db2474086a7e1'],
+    })
+    // .once()


Can we remove this commented code here and in other places?

dan437

LGTM!

test/e2e/tests/smart-transactions/smart-transactions.spec.ts

dbrans · 2024-10-03T15:01:00Z

Spoke with @matthewwalsh0 and will attack these two tasks in follow-up PRs:

Page object model refactor
Add e2e test for dApp smart transaction

metamaskbot · 2024-10-07T18:13:56Z

Builds ready [06d4b97]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1826 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1591	2382	1813	208	100
		domContentLoaded	1586	2366	1783	199	96
		load	1590	2375	1826	202	97
		domInteractive	26	189	57	35	17

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 177 Bytes (0.00%)
ui: 111 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-10-08T13:21:58Z

Builds ready [bfcc184]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1712 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	239	2536	1495	561	269
		domContentLoaded	1437	2521	1691	215	103
		load	1445	2533	1712	213	103
		domInteractive	16	211	50	43	20

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 177 Bytes (0.00%)
ui: 111 Bytes (0.00%)
common: 0 Bytes (0.00%)

vinnyhoward

✅✅✅

chloeYue · 2024-10-10T08:35:29Z

LGTM !

Gudahtt · 2024-10-10T13:00:03Z

privacy-snapshot.json

Where are these calls coming from?

I see that transaction.api.cx.metamask.io is used for smart transactions, and has e2e fetch mocks.

But it's unclear to me why the other two domains have been added, and I don't see any mocks for them.

Gudahtt

Had a couple of questions about the privacy snapshot

sonarcloud · 2024-10-10T16:56:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dbrans requested review from a team as code owners September 17, 2024 13:00

dbrans marked this pull request as draft September 17, 2024 13:00

github-actions bot added the team-transactions Transactions team label Sep 17, 2024

dbrans changed the title ~~test(stx): initial e2e for stx using swaps~~ test(stx): initial e2e for stx using swaps – TXL-308 Sep 17, 2024

dbrans changed the title ~~test(stx): initial e2e for stx using swaps – TXL-308~~ test(TXL-308): initial e2e for stx using swaps Sep 17, 2024

dbrans marked this pull request as ready for review September 17, 2024 13:18

dbrans commented Sep 18, 2024

View reviewed changes

dan437 reviewed Sep 23, 2024

View reviewed changes

test/e2e/tests/smart-transactions/smart-transactions.spec.ts Outdated Show resolved Hide resolved

initial e2e test for stx

db9d7f3

dbrans force-pushed the djb/stx-e2e branch from ac4c7bf to db9d7f3 Compare September 23, 2024 18:46

dan437 reviewed Sep 24, 2024

View reviewed changes

dbrans requested review from a team as code owners September 24, 2024 10:51

dbrans added 2 commits September 24, 2024 06:58

addressing review comments

8496dc1

Merge branch 'develop' into djb/stx-e2e

2a01ebd

dbrans force-pushed the djb/stx-e2e branch from 9fe15fe to 2a01ebd Compare September 24, 2024 10:59

dan437 previously approved these changes Sep 24, 2024

View reviewed changes

Merge branch 'develop' into djb/stx-e2e

a203b50

matthewwalsh0 requested changes Oct 3, 2024

View reviewed changes

test/e2e/tests/smart-transactions/smart-transactions.spec.ts Show resolved Hide resolved

test/e2e/tests/smart-transactions/smart-transactions.spec.ts Show resolved Hide resolved

matthewwalsh0 previously approved these changes Oct 7, 2024

View reviewed changes

Merge branch 'develop' into djb/stx-e2e

decc1b8

dbrans dismissed stale reviews from matthewwalsh0 and dan437 via decc1b8 October 7, 2024 14:31

dbrans added 2 commits October 7, 2024 10:35

yarn lint:fix

4c6472f

fix e2e test

06d4b97

dbrans enabled auto-merge October 7, 2024 18:54

Merge branch 'develop' into djb/stx-e2e

bfcc184

matthewwalsh0 previously approved these changes Oct 9, 2024

View reviewed changes

vinnyhoward previously approved these changes Oct 9, 2024

View reviewed changes

chloeYue previously approved these changes Oct 10, 2024

View reviewed changes

jclancy93 previously approved these changes Oct 10, 2024

View reviewed changes

dbrans added this pull request to the merge queue Oct 10, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024

dbrans added this pull request to the merge queue Oct 10, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024

Gudahtt reviewed Oct 10, 2024

View reviewed changes

Gudahtt requested changes Oct 10, 2024

View reviewed changes

dbrans added 2 commits October 10, 2024 12:42

Merge remote-tracking branch 'origin/develop' into djb/stx-e2e

4d1d241

remove unknown urls from privacy snapshot

d731f26

dbrans dismissed stale reviews from jclancy93, chloeYue, vinnyhoward, and matthewwalsh0 via d731f26 October 10, 2024 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(TXL-308): initial e2e for stx using swaps #27215

test(TXL-308): initial e2e for stx using swaps #27215

dbrans commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024

sonarcloud bot commented Sep 18, 2024

dbrans Sep 18, 2024 •

edited

Loading

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 20, 2024

metamaskbot commented Sep 23, 2024

metamaskbot commented Sep 23, 2024

dan437 Sep 23, 2024

dbrans Sep 24, 2024

dan437 Sep 24, 2024

dbrans Sep 24, 2024

dan437 Sep 24, 2024

dbrans Sep 24, 2024

dan437 left a comment

dbrans commented Oct 3, 2024

metamaskbot commented Oct 7, 2024

metamaskbot commented Oct 8, 2024

vinnyhoward left a comment

chloeYue commented Oct 10, 2024

Gudahtt Oct 10, 2024

Gudahtt Oct 10, 2024

Gudahtt left a comment

sonarcloud bot commented Oct 10, 2024

test(TXL-308): initial e2e for stx using swaps #27215

Are you sure you want to change the base?

test(TXL-308): initial e2e for stx using swaps #27215

Conversation

dbrans commented Sep 17, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 17, 2024

sonarcloud bot commented Sep 18, 2024

Quality Gate passed

dbrans Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

Diff summary

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 20, 2024

metamaskbot commented Sep 23, 2024

metamaskbot commented Sep 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dan437 left a comment

Choose a reason for hiding this comment

dbrans commented Oct 3, 2024

metamaskbot commented Oct 7, 2024

metamaskbot commented Oct 8, 2024

vinnyhoward left a comment

Choose a reason for hiding this comment

chloeYue commented Oct 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gudahtt left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 10, 2024

Quality Gate passed

dbrans commented Sep 17, 2024 •

edited

Loading

dbrans Sep 18, 2024 •

edited

Loading