Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test Simulation Details displays generic error message #27156

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 16, 2024

Description

This test didn't have the mock correctly implemented, making the request take long, thus sometimes failing the test.
The problem is that in the mock, it sets an id of 21however this value is not always the one used in the request.
Since we cannot know which id is going to use, we can omit this param and just match the rest of the request body.

Open in GitHub Codespaces

Related issues

Fixes: #27157

Manual testing steps

  1. Check ci
  2. Run test locally yarn test:e2e:single test/e2e/tests/simulation-details/simulation-details.spec.ts --browser=chrome --leave-running=true

Screenshots/Recordings

See how the request has an id of 0 so it won't be mocked

incorrect-mock-id.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner September 16, 2024 08:34
@seaona seaona self-assigned this Sep 16, 2024
@seaona seaona added team-extension-platform area-qa Relating to QA work (Quality Assurance) labels Sep 16, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Sep 16, 2024
Copy link

sonarcloud bot commented Sep 16, 2024

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (ca6fd53) to head (c4e2948).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #27156   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1442     1442           
  Lines        50100    50100           
  Branches     14006    14006           
========================================
  Hits         35049    35049           
  Misses       15051    15051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c4e2948]
Page Load Metrics (1626 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13792074162817082
domContentLoaded13722056161116680
load13802077162616981
domInteractive208935178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@seaona seaona merged commit 9459903 into develop Sep 16, 2024
98 checks passed
@seaona seaona deleted the fix-simulatons-mock branch September 16, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 16, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix "Simulation Details displays generic error message" flaky tests
4 participants