chore: update Trezor Connect to v9.4.0, remove workarounds #27112

vthomas13 · 2024-09-12T18:14:26Z

This PR includes changes from PR #26749 by @martykan.

Description

With MV3, MetaMask started to use Trezor Connect inside an offscreen environment, in a way that was previously unsupported and required a workaround by patching the Trezor Connect library.

In recent versions of Trezor Connect, the library can handle working in an offscreen environment correctly, without the need for the workaround, which could cause issues with compatibility.

This PR removes the patch and updates the Trezor Connect library to the latest version (v9.4.0).
The change in manifest.json is due to new URL parameters, Firefox needs the asterisk at the end to match the URL with them.
I haven't removed the WebUSB device request which was added on MetaMask's side in relation to the workaround, since it can improve UX of the pairing process, but it could be removed if desired.

The dependency update affects Lavamoat, I am including the policy changes in my commit, however let me know if you would like me to remove them and handle them using your own process.

Related issues

Fixes:

Manual testing steps

Open accounts dropdown, "Add hardware wallet"

Select Trezor

Follow prompts to connect the device

See a list of accounts from the Trezor

Screenshots/Recordings

Before

After

Pre-merge author checklist

[x ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
[x ] I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-12T18:14:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-09-12T18:14:39Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/[email protected]	None	`0`	489 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	52.4 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	506 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	63.7 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	160 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	114 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	106 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	14.1 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	58.5 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	11.8 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	1.89 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	70 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	69.7 kB	existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected]	None	`0`	107 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	200 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	90.8 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	248 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	70.4 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	728 kB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`0`	2.48 MB	nicolo-ribaudo
npm/@emurgo/[email protected]	eval	`0`	3.35 MB	lisicky_emurgo
npm/@emurgo/[email protected]	eval, filesystem	`0`	3.35 MB	lisicky_emurgo
npm/@fivebinaries/[email protected]	None	`0`	149 kB	slowbackspace
npm/@mobily/[email protected]	None	`0`	381 kB	mobily
npm/@sinclair/[email protected]	None	`0`	536 kB	sinclair
npm/@solana/[email protected]	None	`0`	197 kB	steveluscher
npm/@solana/[email protected]	network	`0`	10.9 MB	lorisleiva
npm/@trezor/[email protected]	network	`0`	14 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	56.3 kB	trezor-ci
npm/@trezor/[email protected]	network	`0`	58.4 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	213 kB	trezor-ci
npm/@trezor/[email protected]	environment	`0`	5.41 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	180 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	93.8 kB	trezor-ci
npm/@trezor/[email protected]	filesystem	`0`	1.41 MB	trezor-ci
npm/@trezor/[email protected]	environment	`0`	17.7 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	1.09 MB	trezor-ci
npm/@trezor/[email protected]	None	`0`	11.8 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	38.7 kB	trezor-ci
npm/@trezor/[email protected]	network	`0`	165 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	2.89 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	64.2 kB	trezor-ci
npm/@trezor/[email protected]	None	`0`	234 kB	trezor-ci
npm/@types/[email protected]	None	`0`	8.92 kB	types
npm/@types/[email protected]	None	`0`	1.36 MB	types
npm/[email protected]	network	`0`	43.7 kB	fengmk2
npm/[email protected]	None	`0`	1.56 MB	ealmansi
npm/[email protected]	None	`0`	164 kB	peterolson
npm/[email protected]	None	`0`	55.7 kB	no2chem
npm/[email protected]	None	`0`	7.79 kB	dcousens
npm/[email protected]	None	`0`	4.38 kB	dcousens
npm/[email protected]	None	`0`	410 kB	fanatid
npm/[email protected]	None	`0`	156 kB	dcposch
npm/[email protected]	None	`0`	34.6 kB	volovyk-s
npm/[email protected]	None	`0`	110 kB	ealmansi
npm/[email protected]	filesystem, shell	`0`	62.4 kB	abetomo
npm/[email protected]	None	`0`	11.2 kB	sindresorhus
npm/[email protected]	None	`0`	315 kB	stefanpenner
npm/[email protected]	None	`0`	7.76 kB	digitaldesignlabs
npm/[email protected]	None	`0`	14 kB	indexzero
npm/[email protected]	None	`0`	125 kB	nickyout
npm/[email protected]	None	`0`	3.66 kB	dead_horse
npm/[email protected]	None	`0`	22.2 kB	kawanet
npm/[email protected]	network	`0`	162 kB	tedeh
npm/[email protected]	None	`0`	32 kB	mathias
npm/[email protected]	None	`0`	75.6 kB	tdegrunt
npm/[email protected]	None	`0`	422 kB	kkoopa
npm/[email protected]	None	`0`	4.28 kB	dcousens
npm/[email protected]	None	`0`	47.4 kB	jst5000
npm/[email protected]	None	`0`	1.1 MB	jst5000
npm/[email protected]	None	`0`	24.4 kB	jst5000
npm/[email protected]	None	`0`	147 kB	intelliot
npm/[email protected]	network	`0`	4.9 MB	intelliot
npm/[email protected]	None	`0`	79.4 kB	arv
npm/[email protected]	None	`0`	1.1 MB	junderw
npm/[email protected]	None	`0`	354 kB	sindresorhus
npm/[email protected]	None	`0`	19.1 kB	dcousens
npm/[email protected]	None	`0`	112 kB	faisalman
npm/[email protected]	None	`0`	6.9 MB	thegecko
npm/[email protected]	None	`0`	5.49 kB	junderw
npm/[email protected]	None	`0`	4.67 kB	junderw
npm/[email protected]	environment, network	`0`	147 kB	lpinca

View full report↗︎

socket-security · 2024-09-12T18:14:40Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/@solana/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@solana/[email protected], npm/@trezor/[email protected], npm/@trezor/[email protected], npm/@trezor/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

metamaskbot · 2024-09-12T19:22:17Z

Builds ready [e3aa795]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1516 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	225	2294	1391	419	201
		domContentLoaded	1356	2191	1497	189	91
		load	1364	2283	1516	204	98
		domInteractive	19	57	31	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

metamaskbot · 2024-09-12T22:18:29Z

Builds ready [34f33b3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1805 ± 132 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	225	2737	1727	446	214
		domContentLoaded	1396	2681	1776	278	133
		load	1448	2690	1805	275	132
		domInteractive	12	75	28	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

codecov · 2024-09-12T22:18:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (9459903) to head (9ce641e).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #27112   +/-   ##
========================================
  Coverage    69.95%   69.95%           
========================================
  Files         1441     1441           
  Lines        50099    50099           
  Branches     14007    14007           
========================================
  Hits         35046    35046           
  Misses       15053    15053

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danjm · 2024-09-13T16:41:02Z

@metamaskbot update-policies

metamaskbot · 2024-09-13T16:50:11Z

Policies updated

vthomas13 · 2024-09-13T20:13:32Z

@metamaskbot update-policies

metamaskbot · 2024-09-13T20:23:01Z

No policy changes

metamaskbot · 2024-09-13T20:42:43Z

Builds ready [a840f33]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1727 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	222	2224	1521	553	265
		domContentLoaded	1510	2215	1715	153	73
		load	1523	2224	1727	151	72
		domInteractive	13	102	35	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

sonarcloud · 2024-09-16T13:32:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-16T14:28:42Z

Builds ready [9ce641e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1751 ± 154 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	209	2426	1344	659	316
		domContentLoaded	1434	2459	1736	317	152
		load	1443	2466	1751	320	154
		domInteractive	19	98	38	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

danjm · 2024-09-19T09:12:17Z

@metamaskbot update-policies

metamaskbot · 2024-09-19T09:23:57Z

No policy changes

metamaskbot · 2024-09-19T10:02:23Z

Builds ready [8094f79]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1844 ± 180 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1519	3255	1841	369	177
		domContentLoaded	1512	3115	1812	346	166
		load	1520	3277	1844	375	180
		domInteractive	13	187	47	37	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

vthomas13 · 2024-09-24T14:40:06Z

@metamaskbot update-policies

metamaskbot · 2024-09-24T15:55:35Z

Builds ready [b0def90]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1940 ± 131 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	204	2806	1705	654	314
		domContentLoaded	1626	2798	1918	271	130
		load	1634	2808	1940	273	131
		domInteractive	17	96	42	20	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

vthomas13 · 2024-09-27T15:58:46Z

@metamaskbot update-policies

metamaskbot · 2024-09-27T16:08:19Z

No policy changes

metamaskbot · 2024-09-27T16:33:24Z

Builds ready [b88206c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1761 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	318	2378	1633	439	211
		domContentLoaded	1503	2357	1741	190	91
		load	1511	2377	1761	196	94
		domInteractive	18	69	39	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

metamaskbot · 2024-10-01T18:14:12Z

Builds ready [588ba2b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1756 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1629	1942	1753	86	41
		domContentLoaded	1621	1933	1728	89	43
		load	1629	1942	1756	93	45
		domInteractive	23	122	45	22	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

metamaskbot · 2024-10-03T18:56:37Z

Builds ready [725caae]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1967 ± 142 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1648	3028	1988	312	150
		domContentLoaded	1621	2708	1938	274	132
		load	1632	2876	1967	295	142
		domInteractive	24	76	42	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

danjm · 2024-10-03T19:08:15Z

@SocketSecurity ignore npm/[email protected]

vthomas13 · 2024-10-03T21:48:11Z

@SocketSecurity ignore npm/[email protected] npm/@solana/[email protected]
Verified these authors as members of other open source projects

vthomas13 · 2024-10-04T16:59:59Z

@SocketSecurity ignore npm/[email protected] npm/[email protected] npm/[email protected] npm/[email protected]

npm/[email protected]: it's a widely used library to improve HTTP/HTTPS performance by maintaining persistent connections.
npm/[email protected]: the fallback mechanism ensures the non-native version can still be used in case of an issue with the native code
npm/[email protected]: it's a stable release, but the library is deprecated, so it's good to migrate to xrpl.js as Socket suggests.
npm/[email protected]: It's a cryptographic library, and they usually use native code for performance reasons. However native-code can lead to platform-specific vulnerabilities. It's used in trezor's utxo-lib package

vthomas13 · 2024-10-04T23:48:32Z

@SocketSecurity ignore npm/[email protected] npm/[email protected] npm/[email protected] npm/@solana/[email protected] npm/@trezor/[email protected]

npm/[email protected]: Verified the new author as a member of other open source projects
npm/[email protected], npm/[email protected], npm/@solana/[email protected], npm/@trezor/[email protected]: These are not used in trezor/connect-web, which is what we import.

vthomas13 · 2024-10-05T00:01:19Z

@SocketSecurity ignore npm/@trezor/[email protected] npm/@trezor/[email protected]
npm/@trezor/[email protected], npm/@trezor/[email protected]: These are not used in trezor/connect-web, which is what we import.

metamaskbot · 2024-10-07T15:59:54Z

Builds ready [ba14308]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1991 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	309	2616	1913	434	208
		domContentLoaded	1651	2605	1963	235	113
		load	1699	2630	1991	233	112
		domInteractive	28	194	64	49	23

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

sonarcloud · 2024-10-09T14:25:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-09T14:45:57Z

Builds ready [fd765ae]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1871 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1636	2300	1870	200	96
		domContentLoaded	1621	2291	1843	189	91
		load	1629	2299	1871	198	95
		domInteractive	24	76	44	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 5.55 KiB (0.07%)

vthomas13 requested review from a team as code owners September 12, 2024 18:14

github-actions bot added the team-extension-platform label Sep 12, 2024

vthomas13 force-pushed the marty-trezor-update branch from fe14360 to 922368c Compare September 12, 2024 18:37

vthomas13 force-pushed the marty-trezor-update branch from d5c86db to 0676b39 Compare September 12, 2024 20:49

vthomas13 requested a review from danjm September 12, 2024 21:52

vthomas13 force-pushed the marty-trezor-update branch 3 times, most recently from 8804fcc to 60175c2 Compare September 13, 2024 16:26

vthomas13 force-pushed the marty-trezor-update branch from c8f5607 to a840f33 Compare September 13, 2024 20:12

vthomas13 force-pushed the marty-trezor-update branch from a840f33 to 9ce641e Compare September 16, 2024 13:30

legobeat mentioned this pull request Sep 17, 2024

chore: update Trezor Connect to v9.4.0, remove workarounds #26749

Open

7 tasks

danjm force-pushed the marty-trezor-update branch from 9ce641e to c1350dd Compare September 19, 2024 09:09

vthomas13 force-pushed the marty-trezor-update branch from 8094f79 to 6448cf7 Compare September 24, 2024 14:34

vthomas13 force-pushed the marty-trezor-update branch from 6448cf7 to b0def90 Compare September 24, 2024 14:38

vthomas13 force-pushed the marty-trezor-update branch from b0def90 to b88206c Compare September 27, 2024 15:58

vthomas13 force-pushed the marty-trezor-update branch from b88206c to 588ba2b Compare October 1, 2024 17:42

vthomas13 force-pushed the marty-trezor-update branch from 588ba2b to 725caae Compare October 3, 2024 18:24

vthomas13 force-pushed the marty-trezor-update branch 2 times, most recently from 145a9aa to ba14308 Compare October 7, 2024 14:48

vthomas13 requested a review from a team October 9, 2024 14:13

removing trezor workaround

fd765ae

vthomas13 force-pushed the marty-trezor-update branch from ba14308 to fd765ae Compare October 9, 2024 14:13

danjm approved these changes Oct 10, 2024

View reviewed changes

mikesposito approved these changes Oct 10, 2024

View reviewed changes

vthomas13 added this pull request to the merge queue Oct 10, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024

vthomas13 added this pull request to the merge queue Oct 10, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update Trezor Connect to v9.4.0, remove workarounds #27112

chore: update Trezor Connect to v9.4.0, remove workarounds #27112

vthomas13 commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

socket-security bot commented Sep 12, 2024 •

edited

Loading

socket-security bot commented Sep 12, 2024 •

edited

Loading

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 •

edited

Loading

danjm commented Sep 13, 2024

metamaskbot commented Sep 13, 2024

vthomas13 commented Sep 13, 2024

metamaskbot commented Sep 13, 2024

metamaskbot commented Sep 13, 2024

sonarcloud bot commented Sep 16, 2024

metamaskbot commented Sep 16, 2024

danjm commented Sep 19, 2024

metamaskbot commented Sep 19, 2024

metamaskbot commented Sep 19, 2024

vthomas13 commented Sep 24, 2024

metamaskbot commented Sep 24, 2024

vthomas13 commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Oct 1, 2024

metamaskbot commented Oct 3, 2024

danjm commented Oct 3, 2024

vthomas13 commented Oct 3, 2024

vthomas13 commented Oct 4, 2024

vthomas13 commented Oct 4, 2024

vthomas13 commented Oct 5, 2024

metamaskbot commented Oct 7, 2024

sonarcloud bot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

chore: update Trezor Connect to v9.4.0, remove workarounds #27112

Are you sure you want to change the base?

chore: update Trezor Connect to v9.4.0, remove workarounds #27112

Conversation

vthomas13 commented Sep 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 12, 2024

socket-security bot commented Sep 12, 2024 • edited Loading

socket-security bot commented Sep 12, 2024 • edited Loading

Next steps

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

danjm commented Sep 13, 2024

metamaskbot commented Sep 13, 2024

vthomas13 commented Sep 13, 2024

metamaskbot commented Sep 13, 2024

metamaskbot commented Sep 13, 2024

sonarcloud bot commented Sep 16, 2024

Quality Gate passed

metamaskbot commented Sep 16, 2024

danjm commented Sep 19, 2024

metamaskbot commented Sep 19, 2024

metamaskbot commented Sep 19, 2024

vthomas13 commented Sep 24, 2024

metamaskbot commented Sep 24, 2024

vthomas13 commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Oct 1, 2024

metamaskbot commented Oct 3, 2024

danjm commented Oct 3, 2024

vthomas13 commented Oct 3, 2024

vthomas13 commented Oct 4, 2024

vthomas13 commented Oct 4, 2024

vthomas13 commented Oct 5, 2024

metamaskbot commented Oct 7, 2024

sonarcloud bot commented Oct 9, 2024

Quality Gate passed

metamaskbot commented Oct 9, 2024

vthomas13 commented Sep 12, 2024 •

edited

Loading

socket-security bot commented Sep 12, 2024 •

edited

Loading

socket-security bot commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading