chore: Bump Snaps packages #27057
Merged
chore: Bump Snaps packages #27057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
9b36323
to
a7302e1
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@swc/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@metamaskbot update-policies |
|
Policies updated |
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
98674cd
to
ba235fc
Compare
|
@metamaskbot update-policies |
|
Policies updated |
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
2a996b5
to
b58258c
Compare
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
ced19ad
to
8fa5f28
Compare
|
@metamaskbot update-policies |
|
No policy changes |
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
2 times, most recently
from
5f777e1
to
d60b697
Compare
|
Builds ready [14708a8]
Page Load Metrics (1751 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hmalik88
previously approved these changes
Sep 18, 2024
david0xd
previously approved these changes
Sep 18, 2024
## **Description** This PR adds changes required to enable customizable Input component for Snaps custom UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/26904?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3067 ## **Manual testing steps** 1. Install Snap with custom UI which has customized input with all combinations of start and end accessories. ## **Screenshots/Recordings** ### **Before** Input with additional elements other than button was not supported before (nothing significant to show here). ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Maarten Zuidhoorn <[email protected]> Co-authored-by: Hassan Malik <[email protected]>
…nent (#27106) ## **Description** This PR adds the new `center` attribute to the `Box` component. It allows to apply `align-items: center` to it. [](https://codespaces.new/MetaMask/metamask-extension/pull/27106?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Add support for showing CAIP-10 addresses in Snaps by introducing `SnapUIAddress`. This component mimics the original implementation of `ConfirmInfoRowAddress` but also adds parsing logic for CAIP-10 addresses. CAIP-10 addresses are parsed in the component and the address part is passed to the jazzicon or blockie implementation to render an avatar. The blockie implementation supports arbitrary strings and did not need to be altered. For jazzicons, this PR implements seed generation that is compatible with any address string by seeding the PRNG used for jazzicons with the normalized byte array of the address. Plain Ethereum addresses are still supported and will use the regular jazzicon seed generation logic. This PR will also need a release of the Snaps packages to update the JSX validation to allow passing CAIP-10 addresses. [](https://codespaces.new/MetaMask/metamask-extension/pull/26799?quickstart=1) <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <img width="385" alt="Screenshot 2024-09-02 at 14 35 33" src="https://github.com/user-attachments/assets/344d849b-9121-4bcb-bf58-8cb0b1286112"> <img width="384" alt="Screenshot 2024-09-02 at 14 45 30" src="https://github.com/user-attachments/assets/158e3421-4f9f-46e1-a4cf-93daec45db66">
…27158) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR adds changes required to enable Snaps' footer buttons to submit and reset forms. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/27158?quickstart=1) ## **Related issues** Fixes: MetaMask/snaps#2691 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Small UI adjustments made to Snaps custom UI components. [](https://codespaces.new/MetaMask/metamask-extension/pull/27101?quickstart=1) 1. Go to test snap 2. Try an example snap that renders custom UI   - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Maarten Zuidhoorn <[email protected]>
…27109) ## **Description** This allows a preinstalled snap to disable the snaps branding (headers and icon in buttons) by setting a flag on the preinstalled snap manifest. [](https://codespaces.new/MetaMask/metamask-extension/pull/27109?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1- Got to test-snaps 2- Use the preinstalled example snap ## **Screenshots/Recordings** ### Before   ### After   ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
dismissed stale reviews from vinistevam, hmalik88, and david0xd
via
d3b006d
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
4ad5841
to
d3b006d
Compare
|
david0xd
approved these changes
Sep 19, 2024
vinistevam
approved these changes
Sep 19, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/26904?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27106?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/26799?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27158?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27101?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/27109?quickstart=1){kind=link}
metamaskbot
added
the
release-12.6.0
ritave
approved these changes
Sep 19, 2024
Builds ready [d3b006d]
Page Load Metrics (1663 ± 106 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
release-12.5.0
|
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps Snaps packages to the latest version.