Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test BTC Account - Overview has portfolio button enabled for BTC accounts #27017

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: flaky test BTC Account - Overview has portfolio button enabled for BTC accounts #27017

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee19f7
fix race condition element state
seaona Sep 10, 2024
fe25080
fix lint
seaona Sep 10, 2024
aa6a10c
fix button description
seaona Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions test/e2e/flask/btc/btc-account-overview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { strict as assert } from 'assert';
import { Suite } from 'mocha';
import { withBtcAccountSnap } from './common-btc';

Expand Down Expand Up @@ -30,15 +29,13 @@ describe('BTC Account - Overview', function (this: Suite) {
css: '[disabled]',
});

const buySellButton = await driver.waitForSelector(
'[data-testid="coin-overview-buy"]',
);
assert.equal(await buySellButton.isEnabled(), true);
// buy sell button
await driver.findClickableElement('[data-testid="coin-overview-buy"]');

const portfolioButton = await driver.waitForSelector(
// receive button
await driver.findClickableElement(
'[data-testid="coin-overview-receive"]',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra note: the name of the const is miss-leading, as this is not the portfolio link but the receive button

);
assert.equal(await portfolioButton.isEnabled(), true);
},
);
});
Expand Down