Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 fix typo #27010

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Sep 10, 2024

Description

This PR fixes a typo for two properties that were updated in a recent change to the Segment schema.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Sep 10, 2024
@matteoscurati matteoscurati marked this pull request as ready for review September 10, 2024 07:55
@matteoscurati matteoscurati requested a review from a team as a code owner September 10, 2024 07:55
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 10, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [86d5234]
Page Load Metrics (1792 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15902081180013766
domContentLoaded15822022177313263
load15912083179214168
domInteractive14207464019
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati merged commit 0f8b8eb into develop Sep 10, 2024
77 of 78 checks passed
@matteoscurati matteoscurati deleted the fix/notifications-service-events-fix-typo branch September 10, 2024 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 10, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@metamaskbot metamaskbot added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 16, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.3.0 on PR. Adding release label release-12.3.0 on PR and removing other release labels(release-12.5.0), as PR was cherry-picked in branch 12.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants