Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create Storybook story for ImportSRP component #27000

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 9, 2024

This PR adds a Storybook story for the AddNetworkModal component. The story showcases different states and configurations of the component, improving its testability and documentation.

  1. Reason for the change: To enhance the component's visibility in Storybook and facilitate easier testing and development.
  2. Improvement/solution: Created a new story file with multiple variations of the AddNetworkModal component.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the AddNetworkModal component in the Pages/Onboarding folder.

Screenshots/Recordings

https://files.devinusercontent.com/attachments/5a13b9e8-2468-4532-beea-9545056bb6b0/e3cdc221-da44-45c1-9c05-fcf91c8ff12b.png

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This Devin run was requested by George.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension team-ai AI team (for the Devin AI bot) labels Sep 9, 2024
@georgewrmarshall georgewrmarshall changed the title Create Storybook story for ImportSRP component chore: Create Storybook story for ImportSRP component Sep 9, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review September 9, 2024 22:10
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner September 9, 2024 22:10
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Checked story locally ✅

@metamaskbot
Copy link
Collaborator

Builds ready [36ae543]
Page Load Metrics (1680 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32921871601384185
domContentLoaded141021801666256123
load141721881680256123
domInteractive12147392814
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nit: Is 'HD Key Tree' a constant somewhere?

Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [045248e]
Page Load Metrics (1644 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14632205164720498
domContentLoaded14562092162218488
load14642218164420799
domInteractive19133452612
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [9b300e8]
Page Load Metrics (1775 ± 130 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24025511708433208
domContentLoaded148124971750266128
load149025101775271130
domInteractive12191403718
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall
Copy link
Contributor

No need for coverage as this is a storybook story that doesn't require test coverage

@georgewrmarshall georgewrmarshall merged commit 218d610 into develop Sep 10, 2024
76 of 78 checks passed
@georgewrmarshall georgewrmarshall deleted the devin/story-abc branch September 10, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 10, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants