-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create Storybook story for ImportSRP component #27000
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7a935f5
to
36ae543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Checked story locally ✅
Builds ready [36ae543]
Page Load Metrics (1680 ± 123 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking nit: Is 'HD Key Tree'
a constant somewhere?
Quality Gate failedFailed conditions |
Builds ready [045248e]
Page Load Metrics (1644 ± 99 ms)
Bundle size diffs
|
Builds ready [9b300e8]
Page Load Metrics (1775 ± 130 ms)
Bundle size diffs
|
No need for coverage as this is a storybook story that doesn't require test coverage |
This PR adds a Storybook story for the AddNetworkModal component. The story showcases different states and configurations of the component, improving its testability and documentation.
Related issues
N/A
Manual testing steps
Screenshots/Recordings
https://files.devinusercontent.com/attachments/5a13b9e8-2468-4532-beea-9545056bb6b0/e3cdc221-da44-45c1-9c05-fcf91c8ff12b.pngPre-merge author checklist
Pre-merge reviewer checklist
This Devin run was requested by George.