fix: fix percentage changes when balance is zero

[salimtb]

Description

This PR addresses a UI inconsistency observed in the account balance display, particularly when the account balance is at 0.00. Users have reported confusion over the display of a non-zero percentage change next to a +0.00 change in account value. This scenario occurs when there is no balance (neither in ETH nor in the selected fiat currency, USD in this case) in the user's account. The expectation is that if the account has not increased or decreased in value (due to having no balance), the displayed percentage change should also reflect a 0% change, aligning with the +$0.00 change displayed.

Problem: When the account balance is zero, the UI currently shows a +$0.00 change (as expected) but accompanies this with a non-zero percentage change (e.g., -1.74%), which is misleading and confusing to users. This discrepancy occurs despite the account's value not actually changing, given the lack of funds.

Solution: The proposed solution involves adjusting the logic that calculates and displays the percentage change in account value. Specifically, when the account balance is $0.00, the percentage change should also display as +0.00%, reflecting the true state of the account's value change (or lack thereof). This change ensures consistency in the UI and improves user understanding of their account's status.

Implementation Details:

Modify the calculation function to check for a $0.00 account balance condition. Upon detecting this condition, the function will automatically set the percentage change value to +0.00%.
Update the UI component responsible for displaying the percentage change to correctly render the +0.00% value when the account balance is zero.
Add unit tests to cover this scenario, ensuring that the percentage change correctly reflects a 0% change when the account balance is $0.00.
Expected Outcome: With this fix, users with a 0.00 account balance will see both a +0.00 change and a +0.00% change, eliminating confusion and providing a clearer understanding of their account's status. This update aims to enhance the user experience by ensuring consistency and clarity in the display of account value changes.

Related issues

Fixes: #25539

Manual testing steps

1. Go to the wallet page
2. Select account with 0 native token balance

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [72753de]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (136 ± 185 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	107	80	11	5
		domContentLoaded	8	13	10	1	1
		load	40	1817	136	386	185
		domInteractive	8	13	10	1	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 8 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (6918c52) to head (72753de).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25550   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1349     1349           
  Lines        47850    47850           
  Branches     13195    13196    +1     
========================================
  Hits         33337    33337           
  Misses       14513    14513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcmire]

Makes sense.