Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Snaps code fencing #25523

Merged
merged 5 commits into from
Jun 26, 2024
Merged

chore: Remove Snaps code fencing #25523

merged 5 commits into from
Jun 26, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 26, 2024

Description

This removes code fencing for Snaps, as it is enabled in all build targets.

Closes #25513.

@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team labels Jun 26, 2024
@Mrtenz Mrtenz changed the title Remove Snaps code fencing chore: Remove Snaps code fencing Jun 26, 2024
@Mrtenz Mrtenz removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 26, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 26, 2024
@Mrtenz
Copy link
Member Author

Mrtenz commented Jun 26, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@metamaskbot
Copy link
Collaborator

Policies updated

@Mrtenz Mrtenz force-pushed the mrtenz/remove-snaps-fencing branch from 47526a3 to 49af695 Compare June 26, 2024 13:30
@Mrtenz
Copy link
Member Author

Mrtenz commented Jun 26, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

1 similar comment
@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@metamaskbot
Copy link
Collaborator

Policies updated

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.65%. Comparing base (c27b640) to head (39cb634).
Report is 1 commits behind head on develop.

Files Patch % Lines
...i/pages/confirmations/confirmation/confirmation.js 37.50% 5 Missing ⚠️
...e-container/permission-page-container.component.js 0.00% 4 Missing ⚠️
...i/components/multichain/global-menu/global-menu.js 0.00% 3 Missing ⚠️
...rmissions-connect/permissions-connect.component.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25523      +/-   ##
===========================================
- Coverage    69.66%   69.65%   -0.00%     
===========================================
  Files         1347     1347              
  Lines        47817    47816       -1     
  Branches     13190    13190              
===========================================
- Hits         33307    33306       -1     
  Misses       14510    14510              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [39cb634]
Page Load Metrics (49 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70998273
domContentLoaded9331152
load41704963
domInteractive9331152
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -49 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@Mrtenz Mrtenz marked this pull request as ready for review June 26, 2024 15:22
@Mrtenz Mrtenz requested review from a team as code owners June 26, 2024 15:22
@Mrtenz Mrtenz merged commit dc07c62 into develop Jun 26, 2024
73 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-snaps-fencing branch June 26, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove snaps code fencing
4 participants