chore: Bump Snaps packages #25505
Merged
chore: Bump Snaps packages #25505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [54b1d65]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25505 +/- ##
===========================================
- Coverage 69.70% 69.65% -0.04%
===========================================
Files 1349 1347 -2
Lines 47864 47808 -56
Branches 13205 13187 -18
===========================================
- Hits 33359 33300 -59
- Misses 14505 14508 +3 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/snaps-bump-v53
branch
from
54b1d65
to
187a947
Compare
Builds ready [187a947]
Page Load Metrics (138 ± 162 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This adds the new `Tooltip` component to the Snap custom UI renderer. [](https://codespaces.new/MetaMask/metamask-extension/pull/25413?quickstart=1) Fixes: #25385 1. Go to [tests-snaps](https://metamask.github.io/snaps/test-snaps/latest/). 2. Install the JSX example snap. 3. click `Show JSX dialog`. 4. hover on the `Count` text. 5. Observe the Tooltip <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. -->  - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** This adds a file input component for Snaps to use in custom UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/25320?quickstart=1) ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. --------- Co-authored-by: Frederik Bolding <[email protected]>
FrederikBolding
force-pushed
the
fb/snaps-bump-v53
branch
from
187a947
to
f159706
Compare
Mrtenz
approved these changes
Jun 27, 2024
GuillaumeRx
approved these changes
Jun 27, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/25413?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/25320?quickstart=1){kind=link}
metamaskbot
added
the
release-12.1.0
Builds ready [f159706]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump snaps packages to latest and handle breaking changes.
Summary of changes in the snaps deps:
CheckboxcomponentTooltipcomponentFileInputcomponentalignmentprop toTextsetTimeoutandsetIntervalCloses #25385
Closes MetaMask/snaps#2500
Closes https://github.com/MetaMask/MetaMask-planning/issues/2416