-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable multiple send transactions #25468
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25468 +/- ##
===========================================
- Coverage 64.93% 64.92% -0.01%
===========================================
Files 1385 1385
Lines 54958 54970 +12
Branches 14421 14426 +5
===========================================
+ Hits 35682 35686 +4
- Misses 19276 19284 +8 ☔ View full report in Codecov by Sentry. |
Builds ready [bd0a7e5]
Page Load Metrics (137 ± 180 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
I can't send multiple transactions using send+swap flow:
567.mov |
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0. |
Description
Multiple transactions break STX logic; we need to prevent these transactions from being submitted concurrently. While the confirmations screen covers this, the swap+send flow bypasses this screen altogether, so we need to add logic to prevent submission via the instant submit button (i.e. submit for swap+send).
Related issues
Fixes: #25349
Manual testing steps
Screenshots/Recordings
Before
See: #25349
After
Screen.Recording.2024-06-21.at.11.13.27.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist