fix: fix usd amount in swap notifications

[matteoscurati]

Description

This PR fixes the fiat (USD) conversion for the values displayed in the Swap notifications.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Prithpal-Sooriya]

My only concern is how this is a different method compared to portfolio.

In portfolio we are using Ethers+BigNumber.js so little conversion loss.
But extension may have some formatting.

... we can deal with this in the future lolol

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.96%. Comparing base (9e810ee) to head (7797d88).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25444      +/-   ##
===========================================
+ Coverage    64.95%   64.96%   +0.01%     
===========================================
  Files         1385     1385              
  Lines        54925    54925              
  Branches     14408    14408              
===========================================
+ Hits         35673    35678       +5     
+ Misses       19252    19247       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [7797d88]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (222 ± 252 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	196	89	28	13
		domContentLoaded	9	14	10	1	1
		load	39	1951	222	525	252
		domInteractive	9	14	10	1	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 38 Bytes (0.00%)
• common: 0 Bytes (0.00%)