Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't ignore Yarn patch files #25398

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: Don't ignore Yarn patch files #25398

merged 1 commit into from
Jun 20, 2024

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Jun 18, 2024

An earlier commit modified .gitignore to ignore .yarn files in development/generate-attributions (which is a special sub-project in this repo used in the attribution generation workflow). However, this change ended up ignoring Yarn patch files in .yarn/patches (along with possibly other Yarn-specific files). This commit narrows the pattern in .gitignore not to do this.

Description

Open in GitHub Codespaces

Related issues

See #24390 for PR that introduced the bug that this fixes.

Manual testing steps

  1. Add a file to .yarn/patches.
  2. Run git status.
  3. You should not see it ignored.

Screenshots/Recordings

(None)

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

An earlier commit modified the `.gitignore` to ignore `.yarn` files in
`development/generate-attributions` (which is a special sub-project in
this repo used in the attribution generation workflow). However, this
change ended up ignoring Yarn patch files in `.yarn/patches` (along with
possibly other Yarn-specific files). This commit narrows the gitignore
rule not to do this.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.38%. Comparing base (85783b1) to head (802ae6f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25398   +/-   ##
========================================
  Coverage    65.38%   65.38%           
========================================
  Files         1382     1382           
  Lines        54765    54765           
  Branches     14367    14367           
========================================
  Hits         35807    35807           
  Misses       18958    18958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmire mcmire marked this pull request as ready for review June 18, 2024 22:34
@mcmire mcmire requested a review from a team as a code owner June 18, 2024 22:34
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [802ae6f]
Page Load Metrics (47 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410976115
domContentLoaded8211031
load38704774
domInteractive8211031
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mcmire mcmire merged commit 2ccf3cf into develop Jun 20, 2024
82 of 83 checks passed
@mcmire mcmire deleted the dont-ignore-yarn-patches branch June 20, 2024 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants