-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't ignore Yarn patch files #25398
Conversation
An earlier commit modified the `.gitignore` to ignore `.yarn` files in `development/generate-attributions` (which is a special sub-project in this repo used in the attribution generation workflow). However, this change ended up ignoring Yarn patch files in `.yarn/patches` (along with possibly other Yarn-specific files). This commit narrows the gitignore rule not to do this.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25398 +/- ##
========================================
Coverage 65.38% 65.38%
========================================
Files 1382 1382
Lines 54765 54765
Branches 14367 14367
========================================
Hits 35807 35807
Misses 18958 18958 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [802ae6f]
Page Load Metrics (47 ± 4 ms)
Bundle size diffs
|
An earlier commit modified
.gitignore
to ignore.yarn
files indevelopment/generate-attributions
(which is a special sub-project in this repo used in the attribution generation workflow). However, this change ended up ignoring Yarn patch files in.yarn/patches
(along with possibly other Yarn-specific files). This commit narrows the pattern in.gitignore
not to do this.Description
Related issues
See #24390 for PR that introduced the bug that this fixes.
Manual testing steps
.yarn/patches
.git status
.Screenshots/Recordings
(None)
Pre-merge author checklist
Pre-merge reviewer checklist