fix: failing push notifications

[Prithpal-Sooriya]

Description

This fixes push notifications so that they are not silent push notifications.

Related issues

Fixes:

Manual testing steps

1. Create a wallet notification
2. See push notification received

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Prithpal-Sooriya]

God more bad types we need to resolve.

A raw notification DOES NOT have a type property, this is something we inject before processing. This adds back this type property if it is missing.

[Prithpal-Sooriya]

Most of our types are sound. These are edge-cases and artefacts from the portfolio integration.

[codecov]

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.37%. Comparing base (2aaf565) to head (6db5bfc).
Report is 6 commits behind head on develop.

Files	Patch %	Lines
...s/push-platform-notifications/services/services.ts	0.00%	5 Missing ⚠️
...form-notifications/utils/get-notification-image.ts	50.00%	2 Missing ⚠️
...rm-notifications/utils/get-notification-message.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25340      +/-   ##
===========================================
- Coverage    65.37%   65.37%   -0.00%     
===========================================
  Files         1377     1378       +1     
  Lines        54623    54630       +7     
  Branches     14320    14321       +1     
===========================================
+ Hits         35709    35712       +3     
- Misses       18914    18918       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Prithpal-Sooriya]

This correctly gets the browser image (used on other notifications - e.g. transaction notifications)

[matteoscurati]

Well done!

[chakra-guy]

LGTM

[metamaskbot]

Builds ready [6db5bfc]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (142 ± 196 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	127	82	13	6
		domContentLoaded	9	22	11	3	1
		load	40	1924	142	409	196
		domInteractive	9	22	11	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 945 Bytes (0.03%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)