fix: flaky test screenshot for Increase Token Allowance increases token spending cap to allow other accounts to transfer tokens
#25324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25324 +/- ##
========================================
Coverage 70.44% 70.44%
========================================
Files 1274 1274
Lines 44080 44080
Branches 12453 12453
========================================
Hits 31051 31051
Misses 13029 13029 ☔ View full report in Codecov by Sentry. |
Builds ready [bd7e4d8]
Page Load Metrics (52 ± 4 ms)
Bundle size diffs
|
Builds ready [7478605]
Page Load Metrics (42 ± 3 ms)
Bundle size diffs
|
hjetpoluru
force-pushed
the
flaky-fix-window-token-allowance
branch
from
1b1d283
to
f48a7dc
Compare
hjetpoluru
force-pushed
the
flaky-fix-window-token-allowance
branch
from
97cc7a7
to
39671db
Compare
Builds ready [6b31799]
Page Load Metrics (56 ± 6 ms)
Bundle size diffs
|
…k/metamask-extension into flaky-fix-window-token-allowance
Builds ready [c90292c]
Page Load Metrics (111 ± 141 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Jun 24, 2024
vthomas13
approved these changes
Jun 24, 2024
NiranjanaBinoy
approved these changes
Jun 24, 2024
Builds ready [09b91b3]
Page Load Metrics (43 ± 2 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test fails whenever we try to switch to the MetaMask Dialog.
This PR waits until there are 3 window handles and then performs the window switch. Not sure yet which is the cause of the Dialog not appearing, as I cannot reproduce it locally. However, the benefit of this change is that in the case the dialog does not appear, now we'll be able to take a screenshot and check the artifacts for further information and debugging.
See ci failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87524/workflows/aa81e40a-0aa1-40dc-9ddf-dc83b4db83f1/jobs/3205989/parallel-runs/8?filterBy=FAILED
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
See how no screenshot was taken due to the failure on the window switch
Pre-merge author checklist
Pre-merge reviewer checklist