fix: Fix switch network popup

[NidhiKJha]

This PR is to ensure the network switch modal doesn't show up in a flash when network is switched via the dapp

Related issues

Fixes: #25196

Manual testing steps

1. Go to Pancake swap Dapp
2. Connect MetaMask
3. Switch to Polygon or any network that is not already added to network list in metamask via Dapp
4. Network switch should happen and no modal should up in the flash

Screenshots/Recordings

Before

338417177-79e9c5a7-ba32-4a82-b919-8c65fc27e16f.mov

After

Screen.Recording.2024-06-13.at.2.14.52.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[darkwing]

Approving but we should look into why putting this into shouldShowNetworkInfo is problematic. Thank you Nidhi!

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.63%. Comparing base (0fd5f5e) to head (ab1a7b4).
Report is 11 commits behind head on develop.

Files	Patch %	Lines
ui/pages/routes/routes.component.js	66.67%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25299      +/-   ##
===========================================
- Coverage    65.63%   65.63%   -0.00%     
===========================================
  Files         1375     1375              
  Lines        54553    54555       +2     
  Branches     14294    14296       +2     
===========================================
+ Hits         35803    35804       +1     
- Misses       18750    18751       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [ab1a7b4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (63 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	195	99	23	11
		domContentLoaded	10	59	16	11	5
		load	49	129	63	16	8
		domInteractive	10	59	16	11	5

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 34 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[bergeron]

Looks good to me. I verified the behavior before and after. And I do get the popup when eventually opening MM

[sleepytanya]

Build from current branch, orangefox test account.

What I think might be happening with the network notifications. On the home screen we show notification 'You are now using ***' and user doesn't close it because in order to see this notification user must click on the MM icon or switch to MM tab. When user switches network while having this notification on the home screen then the bug might happen.
The bug is hard to reproduce because the logic to show the notification on the home screen is not strait forward and seems to be related to a number of things.

1. It doesn't look related to the assets on the selected network (e.g. we show notification for the Polygon zkEVM with 0 assets and we don't show notification for the Fuse which also has 0 assets

notif.mov

2. It looks related to the fact if network has been already added / used. The behavior also changes if user tries to add the same network that has been added previously using another dapp.

btChain.mov

Sometimes the logic for showing notification seems absolutely random.

I also observed that sometimes we show notification for such a short time that it is hard to notice but it is still there.

fast.mov

Notification is shown briefly on the home screen:

homeNotif.mov

Notification shown when I connect to sushiswaps and the second notification when switching from Moonbeam to Blast:

sushiBlast.mov

[metamaskbot]

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.