fix: flaky test Full-size View Setting @no-mmi opens the extension in popup view when opened from a dapp after enabling it in Advanced Settings

[seaona]

Description

This PR fixes the flaky test Full-size View Setting @no-mmi opens the extension in popup view when opened from a dapp after enabling it in Advanced Settings.
The problem is that it can take some time to load the window title, making the test fail.
Now, we've added some retry logic, to prevent such cases. See video below

This is a follow-up on @hjetpoluru 's work and investigation, so all credit to her 🙌

#25150

Related issues

Fixes: #24642

Manual testing steps

1. Check ci
2. Run test locally multiple times

Screenshots/Recordings

See how now we enter in the retry loop and the test passes

window-title-retries.mp4

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [fa0c05c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (61 ± 17 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	217	91	30	15
		domContentLoaded	9	19	11	2	1
		load	42	206	61	35	17
		domInteractive	9	19	11	2	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (59a805a) to head (fa0c05c).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25295   +/-   ##
========================================
  Coverage    65.61%   65.61%           
========================================
  Files         1373     1373           
  Lines        54523    54523           
  Branches     14282    14282           
========================================
  Hits         35774    35774           
  Misses       18749    18749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hjetpoluru]

Thanks Mariona.