refactor: use new multichain selectors in accounts related components #25290

ccharly · 2024-06-13T09:26:46Z

Description

This is first work of migrating some components to use the new multichain selectors that have been introduced for non-EVM support within the extension.

None regression is expected with the introduction of those selectors.

Having a pre-PR would make future non-EVM related PRs much simpler to review too.

Related issues

Fixes:

Manual testing steps

Mostly relying on unit and e2e tests here, since there is no new feature

yarn start:flask
Use the extension as usual

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-13T09:27:00Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-06-13T10:04:06Z

Codecov Report

Attention: Patch coverage is 97.43590% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.69%. Comparing base (8539477) to head (99d9128).

Files	Patch %	Lines
ui/selectors/multichain.ts	96.30%	1 Missing ⚠️
ui/selectors/selectors.js	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25290      +/-   ##
===========================================
+ Coverage    65.68%   65.69%   +0.02%     
===========================================
  Files         1377     1377              
  Lines        54593    54624      +31     
  Branches     14304    14314      +10     
===========================================
+ Hits         35854    35885      +31     
  Misses       18739    18739

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-13T10:16:59Z

Builds ready [9315087]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (201 ± 285 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	292	110	54	26
		domContentLoaded	9	83	18	17	8
		load	42	2781	201	593	285
		domInteractive	9	83	17	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 581 Bytes (0.01%)
common: 226 Bytes (0.00%)

…unt-components

ui/selectors/multichain.ts

ui/components/multichain/ramps-card/ramps-card.js

...ponents/app/user-preferenced-currency-display/user-preferenced-currency-display.component.js

…unt-components

metamaskbot · 2024-06-13T12:39:10Z

Builds ready [9023b7d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (52 ± 5 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	115	84	13	6
		domContentLoaded	9	24	11	4	2
		load	39	76	52	11	5
		domInteractive	9	24	11	4	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 569 Bytes (0.01%)
common: 226 Bytes (0.00%)

ui/selectors/selectors.js

ui/selectors/multichain.ts

Co-authored-by: Gustavo Antunes <[email protected]>

…unt-components

metamaskbot · 2024-06-13T16:27:10Z

Builds ready [be53a20]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (52 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	100	82	8	4
		domContentLoaded	10	14	11	1	1
		load	45	66	52	6	3
		domInteractive	10	14	11	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 580 Bytes (0.01%)
common: 233 Bytes (0.00%)

…unt-components

metamaskbot · 2024-06-13T17:12:03Z

Builds ready [79b91bd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (54 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	128	87	14	7
		domContentLoaded	9	13	11	1	1
		load	43	67	54	7	3
		domInteractive	9	13	11	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 580 Bytes (0.01%)
common: 233 Bytes (0.00%)

…unt-components

metamaskbot · 2024-06-13T21:51:32Z

Builds ready [de1e55d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (138 ± 180 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	112	83	14	7
		domContentLoaded	9	15	11	2	1
		load	39	1772	138	375	180
		domInteractive	9	15	11	2	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 580 Bytes (0.01%)
common: 233 Bytes (0.00%)

…unt-components

metamaskbot · 2024-06-14T09:17:37Z

Builds ready [99d9128]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (145 ± 201 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	113	83	14	7
		domContentLoaded	8	32	12	5	2
		load	39	1966	145	418	201
		domInteractive	8	32	12	5	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 580 Bytes (0.01%)
common: 233 Bytes (0.00%)

test(multichain): deep clone evm/non-evm state for each tests

c782bcd

ccharly added 12 commits June 13, 2024 11:27

feat(multichain): better typing + onboarding checks in selectors

00dbae1

fix(multichain): fix getMultichain{CurrentCurrency,DefaultToken}

491bcf2

feat(multichain): add getMultichain{IsMainnet,CurrentChainId} selectors

94621da

refactor(ui): use multichain selectors in AssetList

68c1239

refactor(ui): use multichain selectors in UserPreferencedCurrencyDisplay

6670309

fix(ui): fix AvatarNetwork alt

0ff7cbb

refactor(ui): use multichain selectors in RampsCard

7eb1846

refactor(ui): use multichain selectors in TokenListItem

fa3c43a

refactor(hooks): use multichain selectors in useCurrencyDisplay

a328892

refactor(hooks): use multichain selectors in useUserPreferencedCurrency

82bf937

test(hooks): fix missing multichain stubs/mocks

cefc849

test: re-generate AssetPage snapshot

9315087

ccharly force-pushed the refactor/use-multichain-selectors-in-account-components branch from 1b41d07 to 9315087 Compare June 13, 2024 09:27

ccharly self-assigned this Jun 13, 2024

ccharly added the team-accounts label Jun 13, 2024

ccharly marked this pull request as ready for review June 13, 2024 10:05

ccharly requested review from a team as code owners June 13, 2024 10:05

ccharly added 2 commits June 13, 2024 13:09

refactor(ui): remove some TODO/FIXME

d54864a

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

76598c6

…unt-components

montelaidev reviewed Jun 13, 2024

View reviewed changes

ui/selectors/multichain.ts Show resolved Hide resolved

ui/components/multichain/ramps-card/ramps-card.js Outdated Show resolved Hide resolved

...ponents/app/user-preferenced-currency-display/user-preferenced-currency-display.component.js Outdated Show resolved Hide resolved

ccharly added 2 commits June 13, 2024 14:04

refactor(ui): remove changes related to bitcoin account overview support

b9e6353

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

9023b7d

…unt-components

montelaidev previously approved these changes Jun 13, 2024

View reviewed changes

gantunesr reviewed Jun 13, 2024

View reviewed changes

ui/selectors/selectors.js Outdated Show resolved Hide resolved

ui/selectors/multichain.ts Outdated Show resolved Hide resolved

ui/selectors/multichain.ts Outdated Show resolved Hide resolved

refactor(multichain): use ternary in getMaybeSelectedInternalAccount

11cd32c

Co-authored-by: Gustavo Antunes <[email protected]>

ccharly dismissed montelaidev’s stale review via 11cd32c June 13, 2024 14:57

ccharly and others added 5 commits June 13, 2024 16:57

refactor(multichain): better error message

6be2973

Co-authored-by: Gustavo Antunes <[email protected]>

docs(multichain): add jsdoc for getMultichainProviderConfig

cf24e63

Co-authored-by: Gustavo Antunes <[email protected]>

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

907559f

…unt-components

chore: lint

c2f7a53

docs(multichain): fix doc for getMultichainProviderConfig

be53a20

gantunesr approved these changes Jun 13, 2024

View reviewed changes

garrettbear approved these changes Jun 13, 2024

View reviewed changes

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

79b91bd

…unt-components

ccharly added 2 commits June 13, 2024 22:51

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

74aef5a

…unt-components

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

de1e55d

…unt-components

Merge branch 'develop' into refactor/use-multichain-selectors-in-acco…

99d9128

…unt-components

matthewwalsh0 approved these changes Jun 14, 2024

View reviewed changes

ccharly merged commit b7d7a34 into develop Jun 14, 2024
74 checks passed

ccharly deleted the refactor/use-multichain-selectors-in-account-components branch June 14, 2024 09:19

github-actions bot locked and limited conversation to collaborators Jun 14, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use new multichain selectors in accounts related components #25290

refactor: use new multichain selectors in accounts related components #25290

ccharly commented Jun 13, 2024 •

edited

Loading

github-actions bot commented Jun 13, 2024

codecov bot commented Jun 13, 2024 •

edited

Loading

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 14, 2024

refactor: use new multichain selectors in accounts related components #25290

refactor: use new multichain selectors in accounts related components #25290

Conversation

ccharly commented Jun 13, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 13, 2024

codecov bot commented Jun 13, 2024 • edited Loading

Codecov Report

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 13, 2024

metamaskbot commented Jun 14, 2024

ccharly commented Jun 13, 2024 •

edited

Loading

codecov bot commented Jun 13, 2024 •

edited

Loading