chore: bump keyring-api and eth-snap-keyring

[montelaidev]

Description

This PR bumps @metamask/keyring-api to ^8.0.0 and @metamask/eth-snap-keyring to ^4.3.1

Related issues

Fixes:

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	0	0 B
npm/@metamask/[email protected]	None	+5	326 kB

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

[montelaidev]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[metamaskbot]

Builds ready [8bee890]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (292 ± 343 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	169	94	29	14
		domContentLoaded	8	24	13	5	2
		load	40	2615	292	714	343
		domInteractive	8	24	13	5	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 72.41 KiB (2.17%)
• ui: 0 Bytes (0.00%)
• common: 192 Bytes (0.00%)

[metamaskbot]

Builds ready [f503284]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (51 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	99	84	8	4
		domContentLoaded	8	23	11	3	1
		load	40	73	51	8	4
		domInteractive	8	23	11	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 72.41 KiB (2.17%)
• ui: 0 Bytes (0.00%)
• common: 192 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.62%. Comparing base (453b2b5) to head (f503284).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25287   +/-   ##
========================================
  Coverage    65.62%   65.62%           
========================================
  Files         1373     1373           
  Lines        54532    54532           
  Branches     14285    14285           
========================================
  Hits         35783    35783           
  Misses       18749    18749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ccharly]

LGTM.

Also, we could have avoid the policy changes (or part of them at least) if we had bump the accounts-controller at the same time.

I know it is coming in another PR here: #25291

This PR will probably undo the policy changes we made here, so that's ok

[gantunesr]

LGTM. Will this PR need manual QA @montelaidev?

[montelaidev]

LGTM. Will this PR need manual QA @montelaidev?

Checked with @ccharly we shouldn't need qa for this.