Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Network buttons during advanced onboarding #25276

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Jun 12, 2024

Description

New UI for customizing network RPC during advanced onboarding.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. build with yarn; ENABLE_NETWORK_UI_REDESIGN=1 yarn start
  2. during onboarding, click advanced configuration
  3. Should see the new network buttons, clicks not enabled yet

Screenshots/Recordings

Before

Screenshot 2024-06-12 at 2 28 25 PM

After

Screenshot 2024-06-12 at 2 19 58 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner June 12, 2024 21:33
@bergeron bergeron requested a review from salimtb June 12, 2024 21:33
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.68%. Comparing base (743f5ec) to head (ccbbc69).
Report is 3 commits behind head on develop.

Files Patch % Lines
...boarding-flow/privacy-settings/privacy-settings.js 23.08% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25276      +/-   ##
===========================================
- Coverage    65.68%   65.68%   -0.00%     
===========================================
  Files         1377     1377              
  Lines        54623    54630       +7     
  Branches     14320    14322       +2     
===========================================
+ Hits         35879    35883       +4     
- Misses       18744    18747       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [95430ac]
Page Load Metrics (52 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410585105
domContentLoaded9151111
load44665263
domInteractive9151111
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.81 KiB (0.03%)
  • common: 0 Bytes (0.00%)

@salimtb
Copy link
Contributor

salimtb commented Jun 14, 2024

Just did the QA for this , works as expected for me

salimtb
salimtb previously approved these changes Jun 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ccbbc69]
Page Load Metrics (46 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6410778115
domContentLoaded9141011
load39654673
domInteractive9141011
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.95 KiB (0.03%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron merged commit 1c8ad63 into develop Jun 18, 2024
74 checks passed
@bergeron bergeron deleted the brian/onboarding-network-customizer branch June 18, 2024 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants