Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom network modal form #25213

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 11, 2024

Description

the custom add network form flow is now available on the modal

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Run yarn && ENABLE_NETWORK_UI_REDESIGN=1 yarn start
  2. Go to Settings -> Developer Options
  3. Tun on the network new toggle
  4. Go to the wallet page
  5. Click on the network button ( see the video below )
  6. you should see the list of popular network
    7.click on add network ( you should see the network form )

Screenshots/Recordings

Before

before-add.mov

After

custom-add-afer.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner June 11, 2024 11:59
@salimtb salimtb added team-assets INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 11, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title Add custom network modal form feat: add custom network modal form Jun 11, 2024
@salimtb salimtb requested a review from darkwing June 11, 2024 12:00
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 11, 2024
@salimtb salimtb changed the base branch from develop to add-search-feature June 11, 2024 12:01
@salimtb salimtb force-pushed the add-custom-network-modal-form branch from 1e8a7de to 0c41cf3 Compare June 11, 2024 12:41
@metamaskbot
Copy link
Collaborator

Builds ready [1e8a7de]
Page Load Metrics (236 ± 268 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76229933215
domContentLoaded9151211
load412227236558268
domInteractive9151211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -25.32 KiB (-0.73%)
  • ui: 9.84 KiB (0.14%)
  • common: 25.41 KiB (0.40%)

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 57.37705% with 26 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (c306f20) to head (2aa6a48).

Files Patch % Lines
.../multichain/network-list-menu/network-list-menu.js 54.55% 20 Missing ⚠️
...ttings/networks-tab/networks-form/networks-form.js 70.00% 3 Missing ⚠️
...menu/popular-network-list/popular-network-list.tsx 0.00% 2 Missing ⚠️
...i/pages/onboarding-flow/add-network-modal/index.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25213      +/-   ##
===========================================
- Coverage    65.40%   65.38%   -0.01%     
===========================================
  Files         1382     1382              
  Lines        54736    54765      +29     
  Branches     14353    14367      +14     
===========================================
+ Hits         35795    35807      +12     
- Misses       18941    18958      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1e8a7de]
Page Load Metrics (236 ± 268 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76229933215
domContentLoaded9151211
load412227236558268
domInteractive9151211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -25.32 KiB (-0.73%)
  • ui: 9.84 KiB (0.14%)
  • common: 25.41 KiB (0.40%)

@metamaskbot
Copy link
Collaborator

Builds ready [1e8a7de]
Page Load Metrics (236 ± 268 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76229933215
domContentLoaded9151211
load412227236558268
domInteractive9151211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -25.32 KiB (-0.73%)
  • ui: 9.84 KiB (0.14%)
  • common: 25.41 KiB (0.40%)

@salimtb salimtb force-pushed the add-search-feature branch 2 times, most recently from 6f35f63 to 3c4cb01 Compare June 11, 2024 16:03
bergeron
bergeron previously approved these changes Jun 11, 2024
Copy link
Contributor

@bergeron bergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked locally, was able to add a new network from the modal

@salimtb salimtb force-pushed the add-custom-network-modal-form branch from 0c41cf3 to fbd6e17 Compare June 11, 2024 16:38
@salimtb salimtb force-pushed the add-search-feature branch 5 times, most recently from de40a51 to b71e51e Compare June 13, 2024 09:30
Base automatically changed from add-search-feature to develop June 13, 2024 16:00
@salimtb salimtb dismissed bergeron’s stale review June 13, 2024 16:00

The base branch was changed.

@salimtb salimtb force-pushed the add-custom-network-modal-form branch from d200bcc to 11e0b77 Compare June 14, 2024 10:17
@salimtb salimtb requested a review from a team as a code owner June 14, 2024 10:17
@salimtb salimtb requested a review from darkwing June 14, 2024 10:19
@salimtb salimtb force-pushed the add-custom-network-modal-form branch from 2cb64d3 to 2db5534 Compare June 18, 2024 14:58
bergeron
bergeron previously approved these changes Jun 18, 2024
darkwing
darkwing previously approved these changes Jun 18, 2024
@salimtb salimtb force-pushed the add-custom-network-modal-form branch from 3edd3fa to b10510e Compare June 18, 2024 17:49
bergeron
bergeron previously approved these changes Jun 18, 2024
bergeron
bergeron previously approved these changes Jun 18, 2024
darkwing
darkwing previously approved these changes Jun 18, 2024
@bergeron bergeron dismissed stale reviews from darkwing and themself via 2aa6a48 June 18, 2024 20:00
@metamaskbot
Copy link
Collaborator

Builds ready [2aa6a48]
Page Load Metrics (126 ± 156 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711038484
domContentLoaded9151121
load421543126325156
domInteractive9151121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.37 KiB (0.03%)
  • common: 247 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [2aa6a48]
Page Load Metrics (126 ± 156 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711038484
domContentLoaded9151121
load421543126325156
domInteractive9151121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.37 KiB (0.03%)
  • common: 247 Bytes (0.00%)

@bergeron bergeron merged commit 85783b1 into develop Jun 18, 2024
74 checks passed
@bergeron bergeron deleted the add-custom-network-modal-form branch June 18, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants