feat: filter eth requests for non-EVM accounts #25038

montelaidev · 2024-06-04T16:16:23Z

Description

This PR adds a new middleware to filter EVM requests that goes to non-EVM accounts.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/462

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-04T16:16:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…quests-for-non-evm-accounts

…unts

codecov · 2024-06-07T16:14:41Z

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (e3071f2) to head (c4b6c1f).
Report is 7 commits behind head on develop.

Files	Patch %	Lines
.../scripts/controllers/permissions/specifications.js	66.67%	1 Missing ⚠️
...ateEvmMethodsToNonEvmAccountReqFilterMiddleware.ts	95.65%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25038      +/-   ##
===========================================
+ Coverage    65.65%   65.67%   +0.03%     
===========================================
  Files         1376     1377       +1     
  Lines        54569    54576       +7     
  Branches     14293    14295       +2     
===========================================
+ Hits         35822    35841      +19     
+ Misses       18747    18735      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-07T16:37:18Z

Builds ready [a843ae1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (777 ± 1118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	3998	288	852	409
		domContentLoaded	8	1671	95	362	174
		load	41	10582	777	2329	1118
		domInteractive	8	1671	95	362	174

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.96 KiB (0.06%)
ui: 0 Bytes (0.00%)
common: 482 Bytes (0.01%)

app/scripts/metamask-controller.js

app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts

app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts

…unts

metamaskbot · 2024-06-11T13:20:06Z

Builds ready [8293cc0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (148 ± 179 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	182	100	29	14
		domContentLoaded	9	39	15	8	4
		load	43	1773	148	373	179
		domInteractive	9	39	15	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.78 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 482 Bytes (0.01%)

app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.test.ts

app/scripts/controllers/permissions/specifications.js

app/scripts/lib/createEvmMethodsToNonEvmAccountReqFilterMiddleware.ts

…unts

metamaskbot · 2024-06-13T08:50:09Z

Builds ready [796f872]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (231 ± 265 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	111	82	13	6
		domContentLoaded	9	16	11	2	1
		load	40	1899	231	552	265
		domInteractive	9	16	11	2	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.72 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 482 Bytes (0.01%)

…quests-for-non-evm-accounts

montelaidev · 2024-06-13T16:29:45Z

app/scripts/controllers/mmi-controller.test.ts

@@ -29,6 +29,7 @@ jest.mock('@metamask-institutional/portfolio-dashboard', () => ({
 }));

 jest.mock('./permissions', () => ({
+  ...jest.requireActual('./permissions'),


Only change here in the test. The rest was from linting.

metamaskbot · 2024-06-14T07:52:40Z

Builds ready [c4b6c1f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	112	80	11	5
		domContentLoaded	9	28	12	4	2
		load	40	78	49	9	4
		domInteractive	9	28	12	4	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.72 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 482 Bytes (0.01%)

montelaidev added the team-accounts label Jun 4, 2024

montelaidev self-assigned this Jun 4, 2024

montelaidev requested a review from a team as a code owner June 4, 2024 16:16

montelaidev changed the title ~~Feat/filter eth requests for non evm accounts~~ feat: filter eth requests for non evm accounts Jun 4, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 4, 2024

montelaidev marked this pull request as draft June 4, 2024 16:30

montelaidev added 4 commits June 6, 2024 12:45

feat: add ethMethod filter for nonevm accounts

e47ea35

fix: permission test

be11e02

fix: use older action until v16

437d527

fix: middleware to use RestrictedEthMethods instead of RestrictedMethods

621f65d

montelaidev force-pushed the feat/filter-eth-requests-for-non-evm-accounts branch from 27f9ea4 to 621f65d Compare June 6, 2024 14:38

montelaidev added 5 commits June 6, 2024 23:15

Merge remote-tracking branch 'origin/develop' into feat/filter-eth-re…

bb824e8

…quests-for-non-evm-accounts

fix: update to use restricted messenger

703bc6c

fix: lint

8668fee

fix: eth_requestAccounts

e902361

Merge branch 'develop' into feat/filter-eth-requests-for-non-evm-acco…

a843ae1

…unts

montelaidev marked this pull request as ready for review June 7, 2024 15:31

ccharly reviewed Jun 7, 2024

View reviewed changes

montelaidev added 2 commits June 11, 2024 20:45

refactor: test and comments

e621af6

Merge branch 'develop' into feat/filter-eth-requests-for-non-evm-acco…

8293cc0

…unts

ccharly reviewed Jun 11, 2024

View reviewed changes

montelaidev added 2 commits June 11, 2024 22:32

fix: wallet_requestPermissions test case

bc608ed

fix: styling

e7f1904

ccharly reviewed Jun 12, 2024

View reviewed changes

fix: remove lines and add comment

182f676

montelaidev added 2 commits June 13, 2024 15:18

Merge branch 'develop' into feat/filter-eth-requests-for-non-evm-acco…

2880da4

…unts

chore: add todo comment

25e2a67

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 13, 2024

montelaidev added 2 commits June 13, 2024 16:12

fix: lint

0b65eae

fix: test

796f872

montelaidev added 2 commits June 14, 2024 00:27

fix: move code closer

8a9bf36

Merge remote-tracking branch 'origin/develop' into feat/filter-eth-re…

c4b6c1f

…quests-for-non-evm-accounts

montelaidev commented Jun 13, 2024

View reviewed changes

ccharly approved these changes Jun 13, 2024

View reviewed changes

ccharly changed the title ~~feat: filter eth requests for non evm accounts~~ feat: filter eth requests for non-EVM accounts Jun 13, 2024

gantunesr approved these changes Jun 13, 2024

View reviewed changes

ccharly merged commit 8539477 into develop Jun 14, 2024
80 checks passed

ccharly deleted the feat/filter-eth-requests-for-non-evm-accounts branch June 14, 2024 07:53

github-actions bot locked and limited conversation to collaborators Jun 14, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: filter eth requests for non-EVM accounts #25038

feat: filter eth requests for non-EVM accounts #25038

montelaidev commented Jun 4, 2024 •

edited by ccharly

Loading

github-actions bot commented Jun 4, 2024

codecov bot commented Jun 7, 2024 •

edited

Loading

metamaskbot commented Jun 7, 2024

metamaskbot commented Jun 11, 2024

metamaskbot commented Jun 13, 2024

montelaidev Jun 13, 2024

metamaskbot commented Jun 14, 2024

feat: filter eth requests for non-EVM accounts #25038

feat: filter eth requests for non-EVM accounts #25038

Conversation

montelaidev commented Jun 4, 2024 • edited by ccharly Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 4, 2024

codecov bot commented Jun 7, 2024 • edited Loading

Codecov Report

metamaskbot commented Jun 7, 2024

metamaskbot commented Jun 11, 2024

metamaskbot commented Jun 13, 2024

montelaidev Jun 13, 2024

Choose a reason for hiding this comment

metamaskbot commented Jun 14, 2024

montelaidev commented Jun 4, 2024 •

edited by ccharly

Loading

codecov bot commented Jun 7, 2024 •

edited

Loading