Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter eth request to non-EVM accounts #25003

Merged
merged 12 commits into from
Jun 21, 2024
Merged

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jun 3, 2024

Description

This pr filters eth requests that goes to non evm accounts and also disables the selection of non evm accounts in the permission connect page.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/462

Manual testing steps

  • Affects the accounts list during the dapp connection flow
  • Connection to dapps with an evm account stays the same.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev marked this pull request as ready for review June 3, 2024 16:16
@montelaidev montelaidev requested review from a team as code owners June 3, 2024 16:16
@montelaidev montelaidev changed the title Poc btc eth accounts fix fix: filter eth request to non evm accounts Jun 3, 2024
@montelaidev
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@montelaidev montelaidev changed the base branch from poc-btc to develop June 19, 2024 14:57
@montelaidev
Copy link
Contributor Author

Sorry @k-g-j this pr wasn't up to date when you reviewed it. Whats left is just the ui changes

@montelaidev montelaidev requested review from k-g-j and removed request for a team June 19, 2024 14:58
zone-live
zone-live previously approved these changes Jun 20, 2024
@ccharly ccharly changed the title fix: filter eth request to non evm accounts fix: filter eth request to non-EVM accounts Jun 20, 2024
@montelaidev montelaidev dismissed stale reviews from zone-live and k-g-j via a858d59 June 20, 2024 13:16
zone-live
zone-live previously approved these changes Jun 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a858d59]
Page Load Metrics (47 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62917873
domContentLoaded9131011
load41664773
domInteractive9131011
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.17 KiB (0.02%)
  • common: 215 Bytes (0.00%)

@montelaidev
Copy link
Contributor Author

montelaidev commented Jun 20, 2024

Some points to consider,

  • Add unit tests to ensure the resilience of the component choose-account/choose-account.js

The account-list is a child of the choose-account component and it tests the selection of non-EVM accounts.

@metamaskbot
Copy link
Collaborator

Builds ready [895ae43]
Page Load Metrics (53 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint661018594
domContentLoaded10131111
load46625342
domInteractive10131111
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.85 KiB (0.03%)
  • common: 215 Bytes (0.00%)

ui/helpers/utils/permissions.ts Outdated Show resolved Hide resolved
ui/helpers/utils/permissions.test.ts Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [987a804]
Page Load Metrics (46 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint589679105
domContentLoaded8261042
load38714684
domInteractive8261042
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.63 KiB (0.02%)
  • common: 215 Bytes (0.00%)

@ccharly ccharly merged commit 97edb9a into develop Jun 21, 2024
74 checks passed
@ccharly ccharly deleted the poc-btc-eth-accounts-fix branch June 21, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants