Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Snaps E2E] Create test for snaps interactive ui functions #24884

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented May 29, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: #24721

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders self-assigned this May 29, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.68%. Comparing base (2115516) to head (e57bb82).

Current head e57bb82 differs from pull request most recent head 1868ac3

Please upload reports for the commit 1868ac3 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24884      +/-   ##
===========================================
+ Coverage    65.39%   65.68%   +0.30%     
===========================================
  Files         1382     1377       -5     
  Lines        54764    54623     -141     
  Branches     14369    14320      -49     
===========================================
+ Hits         35809    35879      +70     
+ Misses       18955    18744     -211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FrederikBolding
FrederikBolding previously approved these changes Jun 3, 2024
@bowensanders bowensanders marked this pull request as ready for review June 14, 2024 18:16
@bowensanders bowensanders requested a review from a team as a code owner June 14, 2024 18:16
@metamaskbot
Copy link
Collaborator

Builds ready [e57bb82]
Page Load Metrics (48 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412084147
domContentLoaded8131011
load39804895
domInteractive8131011
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 31 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 5472d47 into develop Jun 20, 2024
76 of 77 checks passed
@FrederikBolding FrederikBolding deleted the bowen/interactiveui branch June 20, 2024 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1868ac3]
Page Load Metrics (47 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint639978105
domContentLoaded8211031
load40724784
domInteractive8211031
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 31 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-snaps release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: [Snaps E2E] Create new interactive UI test
4 participants