-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: percentage increase feature #24223
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1705047
to
d8a6f0b
Compare
ac1c835
to
0c1792c
Compare
Builds ready [0e141e0]
Page Load Metrics (842 ± 578 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24223 +/- ##
===========================================
+ Coverage 65.39% 65.42% +0.04%
===========================================
Files 1382 1384 +2
Lines 54764 54830 +66
Branches 14369 14391 +22
===========================================
+ Hits 35809 35872 +63
- Misses 18955 18958 +3 ☔ View full report in Codecov by Sentry. |
ui/components/multichain/token-list-item/price/percentage-change.tsx
Outdated
Show resolved
Hide resolved
ui/components/multichain/token-list-item/price/percentage-change.tsx
Outdated
Show resolved
Hide resolved
ui/components/multichain/token-list-item/price/percentage-change.tsx
Outdated
Show resolved
Hide resolved
ui/components/multichain/token-list-item/price/percentage-change.tsx
Outdated
Show resolved
Hide resolved
.yarn/patches/@metamask-assets-controllers-patch-55c0923b82.patch
Outdated
Show resolved
Hide resolved
0e141e0
to
cd04145
Compare
cd04145
to
c1cf600
Compare
2360d66
to
59e5fc1
Compare
Builds ready [59e5fc1]
Page Load Metrics (109 ± 135 ms)
Bundle size diffs
|
ui/components/multichain/token-list-item/price/percentage-change/percentage-change.tsx
Outdated
Show resolved
Hide resolved
...ltichain/token-list-item/price/percentage-and-amount-change/percentage-and-amount-change.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits but overall looks great!
59e5fc1
to
7163e90
Compare
Builds ready [7163e90]
Page Load Metrics (48 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/multichain/token-list-item/price/percentage-change/percentage-change.tsx
Outdated
Show resolved
Hide resolved
ui/components/multichain/token-list-item/price/percentage-change/percentage-change.tsx
Outdated
Show resolved
Hide resolved
Builds ready [6035cce]
Page Load Metrics (53 ± 6 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested some different chains, and tokens with/without prices.
I noticed the false positive scam warning on linea, but that's fixed by #25436
nice feature |
Description
This pull request introduces a new feature to the MetaMask extension that enhances user experience by displaying the percentage increase or decrease for each token directly within the UI. This update aims to provide users with immediate visual feedback on the performance of their tokens, helping them make more informed decisions based on recent market trends.
core PR: MetaMask/core#4206
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist