Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in proposed nickname settings #23562

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

coreyjanssen
Copy link
Contributor

@coreyjanssen coreyjanssen commented Mar 18, 2024

Deleting an extraneous "the" in the settings description for proposed nicknames.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Deleting an extraneous "the" in the settings description for proposed nicknames.
@coreyjanssen coreyjanssen requested a review from a team as a code owner March 18, 2024 20:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat requested a review from a team March 19, 2024 21:47
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label May 18, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jun 1, 2024
@legobeat legobeat reopened this Jun 2, 2024
@github-actions github-actions bot removed the stale issues and PRs marked as stale label Jun 2, 2024
@HowardBraham HowardBraham changed the title Fixing typo in proposed nickname settings fix: typo in proposed nickname settings Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (4147b2d) to head (935792d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23562   +/-   ##
========================================
  Coverage    65.42%   65.42%           
========================================
  Files         1380     1380           
  Lines        54688    54688           
  Branches     14339    14339           
========================================
+ Hits         35775    35776    +1     
+ Misses       18913    18912    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HowardBraham HowardBraham merged commit 3820f01 into develop Jun 18, 2024
73 of 74 checks passed
@HowardBraham HowardBraham deleted the coreyjanssen-patch-1 branch June 18, 2024 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [935792d]
Page Load Metrics (47 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62907784
domContentLoaded8201121
load40664773
domInteractive8201121
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -4 Bytes (-0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants