Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced old TextField component with new TextField component on unlock page #20925

Closed
wants to merge 1 commit into from

Conversation

subhajit20
Copy link
Contributor

@subhajit20 subhajit20 commented Sep 17, 2023

Explanation

Replaced old TextField component with new TextField component on unlock page
Issue - #20483

Screenshots/Screencaps

Before
before 2023-09-17 at 9 13 55 AM

After
Screenshot 2023-09-17 at 11 09 21 AM

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@subhajit20 subhajit20 requested a review from a team as a code owner September 17, 2023 05:24
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@subhajit20
Copy link
Contributor Author

@georgewrmarshall Hey can you check and let me know for further correction?
Then will do the rest of the changes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Sep 20, 2023
@subhajit20
Copy link
Contributor Author

subhajit20 commented Sep 21, 2023

Hey @georgewrmarshall , is that above-mentioned TextField component relevant?

@georgewrmarshall
Copy link
Contributor

Hey @subhajit20, this page is rather sensitive to changes. Especially any visual updates so although we do eventually want to update this lock screen with component library components I think it would involve some planning with marketing to let our users know. We don't have the resources right now to do this so for that reason I am going to close this PR

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants