UX: Remove portfolio from global menu

[darkwing]

Explanation

Fixes https://github.com/MetaMask/MetaMask-planning/issues/1069

Screenshots/Screencaps

Manual Testing Steps

1. Open the Global Menu
2. No more Portfolio link

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[garrettbear]

I assume still keeping the Portfolio dashboard content and only removing Portfolio view, so LGTM.
Love deleting code ❤️

Before

This PR

[garrettbear]

tests failed 😢

[darkwing]

tests failed 😢

Ugh, I needed to code-fence a variable -- that doesn't get caught by the local linter. :(

[codecov]

Codecov Report

Merging #20221 (306fb7d) into develop (41f6627) will decrease coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #20221      +/-   ##
===========================================
- Coverage    68.68%   68.67%   -0.00%     
===========================================
  Files          986      986              
  Lines        37870    37865       -5     
  Branches     10138    10138              
===========================================
- Hits         26008    26003       -5     
  Misses       11862    11862              

Files Changed	Coverage Δ
...i/components/multichain/global-menu/global-menu.js	67.27% <100.00%> (-2.73%)	⬇️

[metamaskbot]

Builds ready [306fb7d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1532 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	112	197	133	18	9
		domContentLoaded	1401	1780	1532	85	41
		load	1401	1780	1532	85	41
		domInteractive	1401	1780	1532	85	41

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: -583 Bytes (-0.01%)
• common: -41 Bytes (-0.00%)

[NidhiKJha]

LGTM