Remove unused methods in the transaction controller

[vinistevam]

Explanation

In line with the ongoing initiative to align the transaction controller between the extension and the core repository, this pull request addresses code maintainability by removing two unused methods.

Removed Methods:

• updateTransactionUserSettings
• updateTransactionEstimatedBaseFee

These methods are no longer being used, and their removal will help streamline the codebase and ensure better maintainability going forward. The changes have been carefully tested to avoid any impact on existing functionalities.

• Fixes https://github.com/MetaMask/MetaMask-planning/issues/957

Manual Testing Steps

• Go to Test dApp
• Perform all existing transaction support

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [8aacca4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1709 ± 129 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	355	155	56	27
		domContentLoaded	1427	2342	1707	268	129
		load	1428	2343	1709	268	129
		domInteractive	1427	2342	1707	268	129

Bundle size diffs [🚀 Bundle size reduced!]

• background: -340 Bytes (-0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Merging #20194 (ec2306a) into develop (d262acb) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #20194      +/-   ##
===========================================
- Coverage    68.70%   68.69%   -0.01%     
===========================================
  Files          986      986              
  Lines        37817    37803      -14     
  Branches     10116    10116              
===========================================
- Hits         25979    25965      -14     
  Misses       11838    11838              

Files Changed	Coverage Δ
app/scripts/controllers/transactions/index.js	72.34% <ø> (-0.45%)	⬇️

[metamaskbot]

Builds ready [ec2306a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1637 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	177	132	15	7
		domContentLoaded	1413	2017	1637	148	71
		load	1413	2017	1637	148	71
		domInteractive	1413	2017	1637	148	71

Bundle size diffs [🚀 Bundle size reduced!]

• background: -644 Bytes (-0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)