Fix hover on account menu #20153
Merged
Fix hover on account menu #20153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
garrettbear
commented
Jul 24, 2023
| <Text | ||
| as="div" | ||
| className="multichain-account-list-item__asset" | ||
| display={Display.Flex} | ||
| flexDirection={FlexDirection.Row} | ||
| alignItems={AlignItems.center} | ||
| justifyContent={JustifyContent.flexEnd} |
There was a problem hiding this comment.
@darkwing the alignment felt weird to me, so I added this fix. Not sure if this aligns with design
Before
After
Codecov Report
@@ Coverage Diff @@
## develop #20153 +/- ##
========================================
Coverage 69.37% 69.37%
========================================
Files 986 986
Lines 37290 37290
Branches 10013 10013
========================================
Hits 25867 25867
Misses 11423 11423
|
Builds ready [8988617]
Page Load Metrics (1491 ± 32 ms)
Bundle size diffs
|
garrettbear
requested review from
darkwing,
georgewrmarshall,
vthomas13 and
NidhiKJha
garrettbear
added
team-design-system
darkwing
approved these changes
Jul 24, 2023
Builds ready [7d95e5b]
Page Load Metrics (1541 ± 33 ms)
Bundle size diffs
|
georgewrmarshall
approved these changes
Jul 24, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix underline hover on account menu list items that stemmed from an update on
ButtonLinkcomponent.Screenshots/Screencaps
Before
After
Manual Testing Steps
yarn jest ui/components/multichainPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.