Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused useMethodData code #20146

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

Explanation

Removing unused code in the extension repo. No functional impact.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [3997420]
Page Load Metrics (1616 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99168131209
domContentLoaded14741986161612560
load14741986161612560
domInteractive14741986161612560
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #20146 (7271087) into develop (fdc3558) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #20146      +/-   ##
===========================================
+ Coverage    69.42%   69.44%   +0.02%     
===========================================
  Files          985      984       -1     
  Lines        37294    37284      -10     
  Branches     10012    10011       -1     
===========================================
  Hits         25889    25889              
+ Misses       11405    11395      -10     

@pedronfigueiredo pedronfigueiredo merged commit 83a5090 into develop Jul 25, 2023
9 checks passed
@pedronfigueiredo pedronfigueiredo deleted the fix/remove-use-method-data-code branch July 25, 2023 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 25, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [7271087]
Page Load Metrics (1523 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1083081364421
domContentLoaded13911829152311354
load13911829152311354
domInteractive13911829152311354
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants