feat(882): Optimize metrics function usage during onboarding flow #20101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
DDDDDanica
commented
Jul 19, 2023
| */ | ||
| const onboardingChooseMetametricsOption = async (driver, optin = false) => { |
DDDDDanica
commented
Jul 19, 2023
| * @returns {import('mockttp/dist/pluggable-admin').MockttpClientResponse[]} | ||
| */ | ||
| async function getEventPayloads(driver, mockedEndpoints) { | ||
| async function getEventPayloads(driver, mockedEndpoints, hasRequest = true) { |
There was a problem hiding this comment.
Expand method to test no request scenario as well
DDDDDanica
commented
Jul 19, 2023
| @@ -43,28 +44,6 @@ async function mockSegment(mockServer) { | |||
| ]; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Duplicated in helper.js
DDDDDanica
commented
Jul 19, 2023
| const FixtureBuilder = require('../fixture-builder'); | ||
|
|
||
| describe('Segment metrics', function () { | ||
| describe('Unlock wallet', function () { |
There was a problem hiding this comment.
Move to metrics folder
DDDDDanica
commented
Jul 19, 2023
| }, | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| function assertBatchValue(mockRequest, assertedTitle, assertedPath) { |
There was a problem hiding this comment.
Refactor to make it more readable
danjm
changed the title
pedronfigueiredo
approved these changes
Jul 19, 2023
|
LGTM! |
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Only start
trackEventmethod onui/pages/onboarding-flow/welcome/welcome.jswhen user opts in metrics track on onboarding.Screenshots/Screencaps
Before
Send metric events
before.mov
After
Will not send metric events if not opting in
after.mov
Manual Testing Steps
batchrequest to send metricsPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.