Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Metametrics for Activity Screen #20077

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Adding Metametrics for Activity Screen #20077

merged 2 commits into from
Jul 25, 2023

Conversation

vthomas13
Copy link
Contributor

Explanation

Fixes https://github.com/MetaMask/MetaMask-planning/issues/710

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@vthomas13 vthomas13 requested a review from a team as a code owner July 18, 2023 15:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [c5972b7]
Page Load Metrics (1521 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint111167128147
domContentLoaded1405168715216732
load1405168715216732
domInteractive1405168715216732
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 185 bytes
  • common: 100 bytes

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #20077 (c5972b7) into develop (a8716db) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #20077      +/-   ##
===========================================
+ Coverage    69.43%   69.44%   +0.02%     
===========================================
  Files          990      990              
  Lines        37428    37434       +6     
  Branches     10039    10041       +2     
===========================================
+ Hits         25986    25996      +10     
+ Misses       11442    11438       -4     
Impacted Files Coverage Δ
shared/constants/metametrics.ts 100.00% <100.00%> (ø)
...ction-list-item/transaction-list-item.component.js 74.78% <100.00%> (+4.51%) ⬆️

@vthomas13 vthomas13 merged commit 3e6f1c3 into develop Jul 25, 2023
9 checks passed
@vthomas13 vthomas13 deleted the mc-activity-metrics branch July 25, 2023 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 25, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants