[FLASK] `[email protected]` #20069

FrederikBolding · 2023-07-18T08:50:38Z

Explanation

Bumps Snaps Flask packages to 0.37.1-flask.1 and handles any breaking changes.

This PR also allows snaps using custom UI to disable markdown support in the text component.

metamaskbot · 2023-07-18T09:21:10Z

Builds ready [be9d0ef]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1805 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	130	258	160	29	14
		domContentLoaded	1582	2012	1803	119	57
		load	1582	2012	1805	120	58
		domInteractive	1582	2012	1803	119	57

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 27112 bytes
ui: 0 bytes
common: 0 bytes

codecov · 2023-07-18T09:21:43Z

Codecov Report

Merging #20069 (817c353) into develop (fe3e960) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20069   +/-   ##
========================================
  Coverage    69.46%   69.46%           
========================================
  Files          992      992           
  Lines        37452    37452           
  Branches     10042    10042           
========================================
  Hits         26015    26015           
  Misses       11437    11437

metamaskbot · 2023-07-18T13:00:52Z

Builds ready [3bc643b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1560 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	105	214	133	22	10
		domContentLoaded	1423	1711	1560	86	41
		load	1423	1711	1560	86	41
		domInteractive	1423	1711	1559	86	41

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 27112 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-07-18T22:18:45Z

Builds ready [dd6b41c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1561 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	393	145	59	28
		domContentLoaded	1396	1804	1561	114	55
		load	1396	1804	1561	114	55
		domInteractive	1396	1804	1561	114	55

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 27112 bytes
ui: 0 bytes
common: 0 bytes

bowensanders · 2023-07-18T22:59:34Z

Manual QA passes ✅

metamaskbot · 2023-07-18T23:49:29Z

Builds ready [817c353]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1661 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	106	214	138	27	13
		domContentLoaded	1397	1987	1661	171	82
		load	1397	1987	1661	171	82
		domInteractive	1397	1987	1661	171	82

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 26047 bytes
ui: 0 bytes
common: 0 bytes

FrederikBolding added the flask label Jul 18, 2023

FrederikBolding changed the title ~~[FLASK] [email protected] flask.1~~ [FLASK] [email protected] Jul 18, 2023

FrederikBolding marked this pull request as ready for review July 18, 2023 12:32

FrederikBolding requested review from a team as code owners July 18, 2023 12:32

Mrtenz previously approved these changes Jul 18, 2023

View reviewed changes

FrederikBolding dismissed Mrtenz’s stale review via dd6b41c July 18, 2023 21:48

FrederikBolding changed the title ~~[FLASK] [email protected]~~ [FLASK] [email protected] Jul 18, 2023

Mrtenz previously approved these changes Jul 18, 2023

View reviewed changes

hmalik88 previously approved these changes Jul 18, 2023

View reviewed changes

FrederikBolding added 5 commits July 19, 2023 01:02

[email protected]

9e2ecb4

Update LavaMoat policies

54d2cf3

Add support for disabling markdown

4daee1d

Update execution env URL

350e1e3

Bump patch version

817c353

FrederikBolding dismissed stale reviews from hmalik88 and Mrtenz via 817c353 July 18, 2023 23:05

FrederikBolding force-pushed the fb/[email protected] branch from dd6b41c to 817c353 Compare July 18, 2023 23:05

hmalik88 approved these changes Jul 19, 2023

View reviewed changes

Mrtenz approved these changes Jul 19, 2023

View reviewed changes

FrederikBolding merged commit 56481dd into develop Jul 19, 2023
9 checks passed

FrederikBolding deleted the fb/[email protected] branch July 19, 2023 12:16

github-actions bot locked and limited conversation to collaborators Jul 19, 2023

metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 19, 2023

Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] `[email protected]` #20069

[FLASK] `[email protected]` #20069

FrederikBolding commented Jul 18, 2023 •

edited

Loading

metamaskbot commented Jul 18, 2023

codecov bot commented Jul 18, 2023 •

edited

Loading

metamaskbot commented Jul 18, 2023

metamaskbot commented Jul 18, 2023

bowensanders commented Jul 18, 2023

metamaskbot commented Jul 18, 2023

[FLASK] [email protected] #20069

[FLASK] [email protected] #20069

Conversation

FrederikBolding commented Jul 18, 2023 • edited Loading

Explanation

metamaskbot commented Jul 18, 2023

codecov bot commented Jul 18, 2023 • edited Loading

Codecov Report

metamaskbot commented Jul 18, 2023

metamaskbot commented Jul 18, 2023

bowensanders commented Jul 18, 2023

metamaskbot commented Jul 18, 2023

[FLASK] `[email protected]` #20069

[FLASK] `[email protected]` #20069

FrederikBolding commented Jul 18, 2023 •

edited

Loading

codecov bot commented Jul 18, 2023 •

edited

Loading