Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Use classNames in ConnectedSitesMenu #20067

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

darkwing
Copy link
Contributor

Explanation

Small cleanup to use classNames instead of inline logic for styles

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 18, 2023 02:35
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

NidhiKJha
NidhiKJha previously approved these changes Jul 18, 2023
DDDDDanica
DDDDDanica previously approved these changes Jul 18, 2023
@darkwing darkwing dismissed stale reviews from DDDDDanica and NidhiKJha via c387043 July 18, 2023 22:08
@metamaskbot
Copy link
Collaborator

Builds ready [c387043]
Page Load Metrics (1593 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1173951556431
domContentLoaded1419185315939244
load1419185315939344
domInteractive1419185315939244
Bundle size diffs
  • background: 0 bytes
  • ui: 11 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #20067 (c387043) into develop (5d17f86) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #20067      +/-   ##
===========================================
- Coverage    69.42%   69.42%   -0.00%     
===========================================
  Files          990      990              
  Lines        37418    37416       -2     
  Branches     10039    10037       -2     
===========================================
- Hits         25976    25974       -2     
  Misses       11442    11442              
Impacted Files Coverage Δ
...tichain/connected-site-menu/connected-site-menu.js 100.00% <ø> (ø)

@darkwing darkwing merged commit 1125115 into develop Jul 20, 2023
9 checks passed
@darkwing darkwing deleted the connected-sites-cleanup branch July 20, 2023 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 20, 2023
@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 25, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants