Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Fix Display Property in NFTs #20066

Merged
merged 1 commit into from
Jul 18, 2023
Merged

UX: Fix Display Property in NFTs #20066

merged 1 commit into from
Jul 18, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

Simple fix for misnamed Display enum.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 18, 2023 02:12
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [944a21f]
Page Load Metrics (1460 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint105167119147
domContentLoaded1372158014605727
load1373158114605727
domInteractive1372158014605727
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #20066 (944a21f) into develop (5d17f86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20066   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files          990      990           
  Lines        37418    37418           
  Branches     10039    10039           
========================================
  Hits         25976    25976           
  Misses       11442    11442           
Impacted Files Coverage Δ
ui/components/multichain/nft-item/nft-item.js 100.00% <ø> (ø)

@DDDDDanica
Copy link
Contributor

DDDDDanica commented Jul 18, 2023

Not a blocker: somehow there's regression in other components as well, could. be addressed in another PR if possible :)
https://github.com/MetaMask/metamask-extension/blob/develop/ui/pages/settings/settings.component.js#L168

@garrettbear garrettbear merged commit be469db into develop Jul 18, 2023
9 checks passed
@garrettbear garrettbear deleted the nft-display-block branch July 18, 2023 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 18, 2023
@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 25, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants