Update transaction status to not be considered anonymous

[blackdevelopa]

Explanation

• To include transaction status to the non-anonymous transaction finalised events. See details.
• Fixes #836

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[blackdevelopa]

I have read the CLA Document and I hereby sign the CLA

[segun]

Looks good but e2e is failing.

[metamaskbot]

Builds ready [58eb769]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1510 ± 38 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	102	171	128	15	7
		domContentLoaded	1347	1634	1509	79	38
		load	1347	1634	1510	79	38
		domInteractive	1347	1634	1509	79	38

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #20049 (58eb769) into develop (1277c62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20049   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files          990      990           
  Lines        37418    37418           
  Branches     10039    10039           
========================================
  Hits         25976    25976           
  Misses       11442    11442           

Impacted Files	Coverage Δ
app/scripts/controllers/transactions/index.js	73.00% <ø> (ø)

[blackdevelopa]

Thank you @segun

[bschorchit]

On QA for this: I've downloaded the chrome build for this PR and was able to see the status property on both anonymous and non-anonymous for all transaction events for contract deployment, simple send (legacy and eip1559) and approve transactions.
Looks good to me.

[bschorchit]

I've merged this as I have tested it a bit more today and all looked good ✅