Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing deprecated constants with enums #19860

Merged

Conversation

Jainex17
Copy link
Contributor

@Jainex17 Jainex17 commented Jul 1, 2023

Explanation

This PR is a part of Replace deprecated constants with enums #18714

Changes Made

  • ui/pages/confirmation/components/confirmation-network-switch/confirmation-network-switch.js
  • ui/pages/swaps/list-with-search/list-with-search.js
  • ui/pages/confirmation/templates/add-ethereum-chain.js

Screenshots/Screencaps

Before

ConfirmationNetworkSwitch

ConfirmationNetworkSwitch

After

ConfirmationNetworkSwitch

ConfirmationNetworkSwitch

Cant found other two components in storybook

Here is path of both

  • ui/pages/swaps/list-with-search/list-with-search.js
  • ui/pages/confirmation/templates/add-ethereum-chain.js

Manual Testing Steps

  • Pull this branch
  • Run yarn storybook
  • Check stories for ConfirmationNetworkSwitch

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@Jainex17 Jainex17 requested a review from a team as a code owner July 1, 2023 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #19860 (b048c2f) into develop (6bb5e69) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19860      +/-   ##
===========================================
- Coverage    69.70%   69.70%   -0.01%     
===========================================
  Files          982      982              
  Lines        37071    37071              
  Branches      9944     9944              
===========================================
- Hits         25840    25838       -2     
- Misses       11231    11233       +2     
Impacted Files Coverage Δ
...tion-network-switch/confirmation-network-switch.js 77.78% <ø> (ø)
...pages/confirmation/templates/add-ethereum-chain.js 54.24% <ø> (ø)
...i/pages/swaps/list-with-search/list-with-search.js 36.36% <ø> (ø)

... and 2 files with indirect coverage changes

@Jainex17
Copy link
Contributor Author

Jainex17 commented Jul 2, 2023

Hello @georgewrmarshall Could you please review my pull request?

Thank you!

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @Jainex17

@georgewrmarshall georgewrmarshall merged commit 23c3e8f into MetaMask:develop Jul 12, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension release-10.35.0 Issue or pull request that will be included in release 10.35.0 labels Jul 12, 2023
@Jainex17 Jainex17 deleted the issue/Replace-deprecated-const branch July 13, 2023 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants